server.js: Enable webpack filesystem caching#4523
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4523 +/- ##
==========================================
- Coverage 88.63% 88.48% -0.15%
==========================================
Files 293 287 -6
Lines 25981 25805 -176
Branches 6996 6944 -52
==========================================
- Hits 23027 22834 -193
- Misses 2748 2765 +17
Partials 206 206 see 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
canova
left a comment
There was a problem hiding this comment.
Thanks for the PR! That looks pretty interesting.
I had a similar use case with Julien. I usually start it once and don't stop until I close my laptop (which is like never? :)).
But this would definitely help some people, so I think it's definitely worth landing it.
My main concern was around cache invalidation problems, but we can always revert if it becomes a real problem in the future. Chatted about this a bit on Matrix channel too, Julien was also in favor of landing it.
1771f32 to
a86dc16
Compare
Yeah I noticed, thanks! :) |
As per #4446 (comment). This does seem to be an easy performance win if server.js is invoked multiple times, and it complements #4452.