Skip to content

server.js: Enable webpack filesystem caching#4523

Merged
canova merged 2 commits into
firefox-devtools:mainfrom
kazarmy:server.js-cache-filesystem
Mar 16, 2023
Merged

server.js: Enable webpack filesystem caching#4523
canova merged 2 commits into
firefox-devtools:mainfrom
kazarmy:server.js-cache-filesystem

Conversation

@kazarmy

@kazarmy kazarmy commented Mar 10, 2023

Copy link
Copy Markdown
Contributor

As per #4446 (comment). This does seem to be an easy performance win if server.js is invoked multiple times, and it complements #4452.

@codecov

codecov Bot commented Mar 10, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (f9a5b4e) 88.63% compared to head (1771f32) 88.48%.

❗ Current head 1771f32 differs from pull request most recent head a86dc16. Consider uploading reports for the commit a86dc16 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4523      +/-   ##
==========================================
- Coverage   88.63%   88.48%   -0.15%     
==========================================
  Files         293      287       -6     
  Lines       25981    25805     -176     
  Branches     6996     6944      -52     
==========================================
- Hits        23027    22834     -193     
- Misses       2748     2765      +17     
  Partials      206      206              

see 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kazarmy kazarmy marked this pull request as draft March 11, 2023 01:37
@kazarmy kazarmy marked this pull request as ready for review March 11, 2023 03:46

@canova canova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! That looks pretty interesting.

I had a similar use case with Julien. I usually start it once and don't stop until I close my laptop (which is like never? :)).
But this would definitely help some people, so I think it's definitely worth landing it.

My main concern was around cache invalidation problems, but we can always revert if it becomes a real problem in the future. Chatted about this a bit on Matrix channel too, Julien was also in favor of landing it.

@canova canova force-pushed the server.js-cache-filesystem branch from 1771f32 to a86dc16 Compare March 16, 2023 11:01
@canova canova enabled auto-merge March 16, 2023 11:03
@canova canova merged commit 69ed07f into firefox-devtools:main Mar 16, 2023
@kazarmy

kazarmy commented Mar 16, 2023

Copy link
Copy Markdown
Contributor Author

Chatted about this a bit on Matrix channel too, Julien was also in favor of landing it.

Yeah I noticed, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants