Skip to content

When launching a file automatically, provides the file name to the UR…#4550

Merged
julienw merged 2 commits into
firefox-devtools:mainfrom
julienw:provide-filename-to-server
Mar 28, 2023
Merged

When launching a file automatically, provides the file name to the UR…#4550
julienw merged 2 commits into
firefox-devtools:mainfrom
julienw:provide-filename-to-server

Conversation

@julienw

@julienw julienw commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

…L so that the content-type guesser works for zip files

This was recently added in #4452. But when I wanted to try it with a local zip file, this didn't work as expected because the simple HTTP server doesn't send any content-type, and we weren't using the file name. Therefore the logic couldn't find that this was really a zip file (because we don't sniff the content).

By providing the file name in the requested URL, this now works as expected. You can try it locally by running launch-fp.sh file.zip (launch-fp.sh is in our bin directory).

…L so that the content-type guesser works for zip files
@julienw julienw requested a review from canova March 27, 2023 12:09

@canova canova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@julienw julienw enabled auto-merge (squash) March 28, 2023 12:27
@codecov

codecov Bot commented Mar 28, 2023

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@91a6898). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 8dbb3a3 differs from pull request most recent head 4c0b947. Consider uploading reports for the commit 4c0b947 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4550   +/-   ##
=======================================
  Coverage        ?   88.63%           
=======================================
  Files           ?      293           
  Lines           ?    25981           
  Branches        ?     6996           
=======================================
  Hits            ?    23027           
  Misses          ?     2748           
  Partials        ?      206           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@julienw julienw merged commit 2485c2b into firefox-devtools:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants