When launching a file automatically, provides the file name to the UR…#4550
Merged
julienw merged 2 commits intoMar 28, 2023
Merged
Conversation
…L so that the content-type guesser works for zip files
kazarmy
approved these changes
Mar 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4550 +/- ##
=======================================
Coverage ? 88.63%
=======================================
Files ? 293
Lines ? 25981
Branches ? 6996
=======================================
Hits ? 23027
Misses ? 2748
Partials ? 206 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…L so that the content-type guesser works for zip files
This was recently added in #4452. But when I wanted to try it with a local zip file, this didn't work as expected because the simple HTTP server doesn't send any content-type, and we weren't using the file name. Therefore the logic couldn't find that this was really a zip file (because we don't sniff the content).
By providing the file name in the requested URL, this now works as expected. You can try it locally by running
launch-fp.sh file.zip(launch-fp.shis in ourbindirectory).