server.js: Change working dir to __dirname before starting server#4612
Merged
Conversation
julienw
reviewed
May 9, 2023
Comment on lines
-19
to
-21
| yarn start | ||
| else | ||
| yarn start "$PROFILEPATH" |
Contributor
There was a problem hiding this comment.
yarn start does the switch to root direcotry thing, so probably you didn't need to cd before and after anyway.
But then I believe that relative file paths still wouldn't work without resolving them with realpath first.
Then I believe your change makes sense and is simple enough.
Thanks!
julienw
approved these changes
May 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr makes
server.jschange its working directory to__dirnamebefore starting the webpack server, thus allowingserver.jsto be run from anywhere on the file system and greatly simplifyingbin/launch-fp.sh.