Skip to content

Improve the behavior of various views when a profile has a long name#4619

Merged
julienw merged 2 commits into
firefox-devtools:mainfrom
julienw:4615-fix-bad-layout-long-profile-name
May 16, 2023
Merged

Improve the behavior of various views when a profile has a long name#4619
julienw merged 2 commits into
firefox-devtools:mainfrom
julienw:4615-fix-bad-layout-long-profile-name

Conversation

@julienw

@julienw julienw commented May 15, 2023

Copy link
Copy Markdown
Contributor

Fixes #4615

If you want to try it, you can reupload this profile.

image
image
image

@codecov

codecov Bot commented May 15, 2023

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@ebdbcd5). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head a7db1ed differs from pull request most recent head e8f48e6. Consider uploading reports for the commit e8f48e6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4619   +/-   ##
=======================================
  Coverage        ?   88.63%           
=======================================
  Files           ?      294           
  Lines           ?    26086           
  Branches        ?     7030           
=======================================
  Hits            ?    23121           
  Misses          ?     2759           
  Partials        ?      206           
Impacted Files Coverage Δ
src/components/app/ProfileDeleteButton.js 93.33% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@julienw julienw requested a review from canova May 15, 2023 19:10

@canova canova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Comment thread src/components/app/Home.css Outdated
margin-top: 30px;
column-gap: 30px;
grid-template-columns: 1fr 1fr;
grid-template-columns: minmax(0, 1fr) minmax(0, 1fr); /* minmax makes the grid ignore the element's intrinsic size. */

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, TIL!

Comment thread src/components/app/Home.css
@julienw julienw force-pushed the 4615-fix-bad-layout-long-profile-name branch from a7db1ed to e8f48e6 Compare May 16, 2023 15:13
@julienw julienw merged commit be9c9bf into firefox-devtools:main May 16, 2023
@canova canova mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad home page layout after uploading a profile with a long name

2 participants