Add the minute and hour units for duration formats#4621
Conversation
|
It would also be nice to make the code in src/components/timeline/Ruler.js handle nicely profiles with long durations, but that code is more complicated to tweak so I think it could be done in a separate future pull request. I'm not even sure yet what the correct behavior would look like for what to display in the timeline ruler. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4621 +/- ##
=======================================
Coverage 88.62% 88.62%
=======================================
Files 294 294
Lines 26090 26100 +10
Branches 7031 7038 +7
=======================================
+ Hits 23122 23131 +9
- Misses 2762 2763 +1
Partials 206 206
☔ View full report in Codecov by Sentry. |
julienw
left a comment
There was a problem hiding this comment.
This looks reasonable, thanks!
| "duration - 12.346ms", | ||
| "duration - 123.46s", | ||
| "duration - 2.06min", | ||
| "duration - 34.3h", |
Yeah, it's not clear to me either. |
When making very long (many hours, sometimes multiple days) profiles to understand power use, having the profile range displayed as a value of multiple thousand seconds is not user friendly.
Example long profile: https://profiler.firefox.com/public/xgdwbaq634je6227x9ar8y68ayfmzm3f9vty560/