Add the kWh unit for tooltips of power tracks.#4622
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4622 +/- ##
==========================================
- Coverage 88.63% 88.62% -0.01%
==========================================
Files 294 294
Lines 26086 26090 +4
Branches 7030 7031 +1
==========================================
+ Hits 23121 23122 +1
- Misses 2759 2762 +3
Partials 206 206
☔ View full report in Codecov by Sentry. |
flodolo
approved these changes
May 16, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When power profiling something that uses more power than a browser on a laptop (could be an application using all cores for multiple hours on a powerful server, or in my most recent case kitchen appliances or washing machines), having a Wh as the largest unit means we display numbers in the thousands in tooltips of the power track. Adding the 'kilo' version of the existing units is straightforward.
Example profile: https://share.firefox.dev/430KJTk (this is using the washing machine, then the dryer)