Skip to content

Set the CanvasRenderingContext2D.lineJoin to bevel on power tracks#4634

Merged
julienw merged 1 commit into
firefox-devtools:mainfrom
fqueze:powerLineJoin
May 26, 2023
Merged

Set the CanvasRenderingContext2D.lineJoin to bevel on power tracks#4634
julienw merged 1 commit into
firefox-devtools:mainfrom
fqueze:powerLineJoin

Conversation

@fqueze

@fqueze fqueze commented May 26, 2023

Copy link
Copy Markdown
Contributor

The power tracks have very noisy graphs on https://share.firefox.dev/3OKB7bB

Per discussion on matrix, the way to fix it is to set https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/lineJoin

deploy preview

…tracks to avoid visual noise on dense charts.
@fqueze fqueze requested a review from julienw May 26, 2023 17:06

@julienw julienw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better!

Maybe we should do this for other similar graphs, I'm thinking of the CPU graph for example. What do you think @canova ?

@julienw julienw merged commit c3f2c3f into firefox-devtools:main May 26, 2023
@canova

canova commented May 26, 2023

Copy link
Copy Markdown
Member

I agree, I think it would be good to do it for others as well. Looks so much better this way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants