Skip to content

changed lineJoin values of memory graph, process CPU graph and event …#4647

Merged
canova merged 1 commit into
firefox-devtools:mainfrom
zubaer-khan:zubaer-khan-bevel
May 31, 2023
Merged

changed lineJoin values of memory graph, process CPU graph and event …#4647
canova merged 1 commit into
firefox-devtools:mainfrom
zubaer-khan:zubaer-khan-bevel

Conversation

@zubaer-khan

@zubaer-khan zubaer-khan commented May 30, 2023

Copy link
Copy Markdown
Contributor

…delay graph

Fixes #4644.

@codecov

codecov Bot commented May 30, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (04a2eba) 88.47% compared to head (7d47a74) 88.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4647   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files         295      295           
  Lines       26210    26213    +3     
  Branches     7068     7068           
=======================================
+ Hits        23190    23193    +3     
  Misses       2809     2809           
  Partials      211      211           
Impacted Files Coverage Δ
src/components/timeline/TrackEventDelayGraph.js 98.18% <100.00%> (+0.01%) ⬆️
src/components/timeline/TrackMemoryGraph.js 92.35% <100.00%> (+0.04%) ⬆️
src/components/timeline/TrackProcessCPUGraph.js 93.79% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@julienw julienw requested a review from canova May 31, 2023 09:29

@canova canova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks your contribution!

Here's a before and after pics with this PR.
Before:
Screenshot 2023-05-31 at 2 57 25 PM
After:
Screenshot 2023-05-31 at 2 58 06 PM
It's just a random profile but already process CPU graph looks a lot better!

@canova canova merged commit acb9e66 into firefox-devtools:main May 31, 2023
@canova canova mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the lineJoin values of some graphs to make them less noisy

2 participants