Remove use of AWS stage server#4651
Merged
Merged
Conversation
Contributor
|
Thanks, could you fix the test as well? profiler/src/test/url-handling.test.js Line 1822 in acb9e66 |
Contributor
Author
|
Not easily. I can get to it tomorrow, though. |
This removes the host that pointed to the stage environment in AWS for the Mozilla Symbolication Service. That host no longer works. See https://bugzilla.mozilla.org/show_bug.cgi?id=1836055
Contributor
Author
|
^^^ That fixes the tests. I'm not sure what the AppVeyor build is failing on. Is that related to these changes? If so, any idea on how I can fix it? |
julienw
approved these changes
Jun 6, 2023
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, thanks!
Looks like the appveyor issue was spurious, retriggering the test made it pass.
Contributor
Author
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the host that pointed to the stage environment in AWS for the Mozilla Symbolication Service. That host no longer works.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1836055