Update eslint-plugin-jest-dom 4.0.3 → 5.0.1 (major)#4662
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4662 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 295 295
Lines 26290 26290
Branches 7097 7097
=======================================
Hits 23260 23260
Misses 2818 2818
Partials 212 212 ☔ View full report in Codecov by Sentry. |
canova
approved these changes
Jun 13, 2023
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Looks like they made the @testing-library/dom library a peer dependency and required. But we already have that dependency in our project, so we don't need to do anything special.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ eslint-plugin-jest-dom (4.0.3 → 5.0.1) · Repo
Release Notes
5.0.1
5.0.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 17 commits:
fix(prefer-to-have-style): do not offer invalid autofix for computed accessors (#306)fix(getQueryNodeFrom): move `Identifier` type checks to `getInnerNodeFrom` (#255)chore: update `@testing-library/dom` version in `devDependencies`chore: add `@testing-library/dom` to `devDependencies` (#305)feat: make `@testing-library/dom` a peer dependency (#304)chore(deps): bump AriPerkkio/eslint-remote-tester-run-action from 3 to 4 (#302)chore: use flat-square style for badges (#299)chore: remove `styfle/cancel-workflow-action` usage (#300)chore: fix badges (#298)chore(deps-dev): bump eslint-remote-tester-repositories (#292)chore(deps-dev): bump eslint-doc-generator from 0.26.1 to 1.0.0 (#285)ci: dont fail fast (#284)chore(deps-dev): bump eslint-doc-generator from 0.25.0 to 0.26.0 (#283)chore(deps-dev): bump eslint-doc-generator from 0.22.0 to 0.25.0 (#282)chore(deps-dev): bump eslint-doc-generator from 0.21.0 to 0.22.0 (#281)chore(deps): bump cycjimmy/semantic-release-action from 2 to 3 (#280)chore(deps-dev): bump eslint-doc-generator from 0.19.1 to 0.21.0 (#279)Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands