Improve memoization of getCallNodeInfo.#4667
Merged
mstange merged 1 commit intoJun 20, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4667 +/- ##
==========================================
- Coverage 88.47% 88.47% -0.01%
==========================================
Files 295 295
Lines 26299 26291 -8
Branches 7100 7097 -3
==========================================
- Hits 23269 23261 -8
Misses 2818 2818
Partials 212 212
☔ View full report in Codecov by Sentry. |
With this change, zooming in on a range and dropping a function gets much faster on large profiles because we don't recompute the call node table.
mstange
force-pushed
the
better-memoization-for-getcallnodeinfo
branch
from
ce37c9b to
8a761ba
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production, Deploy preview
With this change, zooming in on a range and dropping a function gets much faster on large profiles because we don't recompute the call node table.