Speed up focusFunction with a typed array. #4671
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4671 +/- ##
==========================================
- Coverage 88.49% 88.49% -0.01%
==========================================
Files 296 296
Lines 26318 26314 -4
Branches 7102 7103 +1
==========================================
- Hits 23290 23286 -4
Misses 2816 2816
Partials 212 212
☔ View full report in Codecov by Sentry. |
mstange
force-pushed
the
faster-focus-function
branch
from
aaf28d9 to
ef309ad
Compare
This speeds up focusFunction on https://share.firefox.dev/3CvZmmy by 7x, from 643ms to 89ms. Before: https://share.firefox.dev/3PiMYhp After: https://share.firefox.dev/3XfPabA
mstange
force-pushed
the
faster-focus-function
branch
from
ef309ad to
4488f89
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This speeds up focusFunction on https://share.firefox.dev/3CvZmmy by 7x, from 643ms to 89ms.
Before: https://share.firefox.dev/3PiMYhp
After: https://share.firefox.dev/3XfPabA