Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/components/shared/thread/SampleGraph.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import type {
CategoryList,
IndexIntoSamplesTable,
Milliseconds,
CallNodeInfo,
IndexIntoCallNodeTable,
SelectedState,
} from 'firefox-profiler/types';
Expand All @@ -34,7 +33,6 @@ type Props = {|
+interval: Milliseconds,
+rangeStart: Milliseconds,
+rangeEnd: Milliseconds,
+callNodeInfo: CallNodeInfo,
+categories: CategoryList,
+onSampleClick: (
event: SyntheticMouseEvent<>,
Expand Down Expand Up @@ -96,7 +94,6 @@ export class ThreadSampleGraphImpl extends PureComponent<Props> {
interval,
rangeStart,
rangeEnd,
callNodeInfo,
samplesSelectedStates,
sampleCallNodes,
categories,
Expand All @@ -110,13 +107,6 @@ export class ThreadSampleGraphImpl extends PureComponent<Props> {
canvas.width = Math.round(width * devicePixelRatio);
canvas.height = Math.round(height * devicePixelRatio);
const ctx = canvas.getContext('2d');
let maxDepth = 0;
const { callNodeTable } = callNodeInfo;
for (let i = 0; i < callNodeTable.depth.length; i++) {
if (callNodeTable.depth[i] > maxDepth) {
maxDepth = callNodeTable.depth[i];
}
}
const range = [rangeStart, rangeEnd];
const rangeLength = range[1] - range[0];
const xPixelsPerMs = canvas.width / rangeLength;
Expand Down
3 changes: 0 additions & 3 deletions src/components/sidebar/CallTreeSidebar.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import type { ConnectedProps } from 'firefox-profiler/utils/connect';
import type {
ThreadsKey,
CategoryList,
CallNodeTable,
IndexIntoCallNodeTable,
TracedTiming,
Milliseconds,
Expand Down Expand Up @@ -286,7 +285,6 @@ export const CategoryBreakdown = explicitConnect<

type StateProps = {|
+selectedNodeIndex: IndexIntoCallNodeTable | null,
+callNodeTable: CallNodeTable,
+selectedThreadsKey: ThreadsKey,
+name: string,
+lib: string,
Expand Down Expand Up @@ -503,7 +501,6 @@ class CallTreeSidebarImpl extends React.PureComponent<Props> {
export const CallTreeSidebar = explicitConnect<{||}, StateProps, {||}>({
mapStateToProps: (state) => ({
selectedNodeIndex: selectedThreadSelectors.getSelectedCallNodeIndex(state),
callNodeTable: selectedThreadSelectors.getCallNodeInfo(state).callNodeTable,
selectedThreadsKey: getSelectedThreadsKey(state),
name: getFunctionName(selectedNodeSelectors.getName(state)),
lib: selectedNodeSelectors.getLib(state),
Expand Down
1 change: 0 additions & 1 deletion src/components/timeline/TrackThread.js
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ class TimelineTrackThreadImpl extends PureComponent<Props> {
thread={filteredThread}
rangeStart={rangeStart}
rangeEnd={rangeEnd}
callNodeInfo={callNodeInfo}
sampleCallNodes={sampleCallNodes}
samplesSelectedStates={samplesSelectedStates}
categories={categories}
Expand Down
2 changes: 0 additions & 2 deletions src/profile-logic/transforms.js
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,6 @@ export function applyTransformToCallNodePath(
return _startCallNodePathWithFunction(transform.funcIndex, callNodePath);
case 'focus-category':
return _removeOtherCategoryFunctionsInNodePathWithFunction(
transformedThread,
transform.category,
callNodePath,
callNodeTable
Expand Down Expand Up @@ -597,7 +596,6 @@ function _dropFunctionInCallNodePath(

// removes all functions that are not in the category from the callNodePath
function _removeOtherCategoryFunctionsInNodePathWithFunction(
thread: Thread,
category: IndexIntoCategoryList,
callNodePath: CallNodePath,
callNodeTable: CallNodeTable
Expand Down