Make the flame graph and stack chart always non-inverted#4804
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4804 +/- ##
==========================================
+ Coverage 88.25% 88.27% +0.01%
==========================================
Files 301 301
Lines 26870 26912 +42
Branches 7262 7284 +22
==========================================
+ Hits 23715 23756 +41
- Misses 2937 2938 +1
Partials 218 218 ☔ View full report in Codecov by Sentry. |
julienw
approved these changes
Nov 22, 2023
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this looks good to me!
I only have one suggestion regarding the caching of the inverted tree. Otherwise a few simple nits.
Tell me what you think :-)
Compute the inverted selected call node in the action creator, not in the reducer. This means we don't have to pass the call tree as far down. Also move the computation into the CallTree class. And fix it to stop at nodes with heaviest self time, even if they're not leaf nodes.
…anded call paths in the redux state.
This means that the flame graph and the stack chart will now always display un-inverted. Fixes firefox-devtools#3961. Fixes firefox-devtools#4803.
…nverted and non-inverted views.
This makes it faster to switch back and forth between inverted and non-inverted mode. It also makes it faster to switch tabs between inverted call tree and the chart views which are always non-inverted.
mstange
force-pushed
the
no-inverted-charts
branch
from
57fc8e0 to
3c0c07c
Compare
Merged
mstange
added a commit
to mstange/perf.html
that referenced
this pull request
Aug 6, 2024
The stack chart is now always inverted. I forgot to remove this test in firefox-devtools#4804.
mstange
added a commit
to mstange/perf.html
that referenced
this pull request
Aug 6, 2024
The stack chart is now always non-inverted. I forgot to remove this test in firefox-devtools#4804.
mstange
added a commit
to mstange/perf.html
that referenced
this pull request
Aug 7, 2024
The stack chart is now always non-inverted. I forgot to remove this test in firefox-devtools#4804.
mstange
added a commit
that referenced
this pull request
Aug 7, 2024
The stack chart is now always non-inverted. I forgot to remove this test in #4804.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production | Deploy preview
Fixes #3961.
Fixes #4803.
As an added benefit, this simplifies the work for #337 because we won't need special code for the inverted stack chart.
This PR doesn't remove the code for the warning on the flame graph; I'd be happy to leave this cleanup to someone else.