Use a call node path to make the stack copy string.#4811
Merged
Conversation
This is a minor simplification and removes some raw callNodeTable usage.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4811 +/- ##
=======================================
Coverage ? 88.27%
=======================================
Files ? 301
Lines ? 26909
Branches ? 7284
=======================================
Hits ? 23753
Misses ? 2938
Partials ? 218 ☔ View full report in Codecov by Sentry. |
julienw
approved these changes
Nov 27, 2023
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
sounds good to me
I was a bit worried that this makes us loop over the call node path twice, but it's not a big deal for this copy operation.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor simplification and removes some raw callNodeTable usage.