Only set fillStyle once in drawSamples.#4816
Merged
Merged
Conversation
Move the fillStyle setting outside of a loop in the SampleGraph implementation. This was likely moved by mistake in f8631ae . And don't set the fillStyle at all if there's nothing to draw with this color.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4816 +/- ##
=======================================
Coverage 88.27% 88.27%
=======================================
Files 301 301
Lines 26911 26915 +4
Branches 7284 7286 +2
=======================================
+ Hits 23755 23759 +4
Misses 2938 2938
Partials 218 218 ☔ View full report in Codecov by Sentry. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the fillStyle setting outside of a loop in the SampleGraph implementation. This was likely moved by mistake in f8631ae .
And don't set the fillStyle at all if there's nothing to draw with this color.