Skip to content

Improve flame graph performance. #4820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstange merged 2 commits into from
Nov 30, 2023
Merged

Improve flame graph performance. #4820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b537cb
Work around Math.abs being slow in Firefox in React development envir…
mstange Nov 28, 2023
30ae592
Improve flame graph performance by caching rows.
mstange Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/profile-logic/call-tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,9 @@ export function computeCallTreeCountsAndSummary(
let rootTotalSummary = 0;
let rootCount = 0;

// Workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=1858310
const abs = Math.abs;
Comment thread
mstange marked this conversation as resolved.

// We loop the call node table in reverse, so that we find the children
// before their parents, and the total is known at the time we reach a
// node.
Expand All @@ -538,7 +541,7 @@ export function computeCallTreeCountsAndSummary(
callNodeIndex--
) {
callNodeTotalSummary[callNodeIndex] += callNodeLeaf[callNodeIndex];
rootTotalSummary += Math.abs(callNodeLeaf[callNodeIndex]);
rootTotalSummary += abs(callNodeLeaf[callNodeIndex]);
const hasChildren = callNodeChildCount[callNodeIndex] !== 0;
const hasTotalValue = callNodeTotalSummary[callNodeIndex] !== 0;

Expand Down
Loading