Add sanitized-string format#5007
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5007 +/- ##
=======================================
Coverage 88.48% 88.49%
=======================================
Files 304 304
Lines 27393 27398 +5
Branches 7400 7402 +2
=======================================
+ Hits 24240 24245 +5
Misses 2931 2931
Partials 222 222 ☔ View full report in Codecov by Sentry. |
julienw
left a comment
There was a problem hiding this comment.
I should have told you earlier, sorry about that.
You need to add some code to display the data as well:
profiler/src/profile-logic/marker-schema.js
Line 475 in 07b78f6
You can also add one case in
profiler/src/test/unit/marker-schema.test.js
Line 207 in 07b78f6
After that I think it will be good to go for the frontend part! (but let's wait that the c++ part is ready, just to make sure the version numbers do not change in-between).
julienw
left a comment
There was a problem hiding this comment.
Thanks for all the added tests and types, this looks good to me now!
We can land it as soon as the gecko part is ready too. I'm gonna ping Adam to have a look at it today.
274f448 to
4fe78ba
Compare
|
@julienw appveyor failed because of a nvm issue. |
|
Seems all green now. |
|
appveyor isn't marked as "required" here, esp because it tends to fail sometimes like you've seen. It's more here for our information. |
See ⚙ D211171 Bug 1898171 - Add SanitizedString profiler marker format r=acreskey,julienw
This change adds the ability to sanitize fields that are not URLs or FilePaths.
This is necessary when we want to add domains or other PII fields that are not exactly the same as URL or FilePath.