Update fake-indexeddb 5.0.2 → 6.0.0 (major)#5011
Merged
Merged
Conversation
Contributor
Member
|
Oops thanks for reminding me @julienw! I just landed that one, let's rebase this. @depfu rebase |
4f1c421 to
4f4287e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5011 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 304 304
Lines 27393 27393
Branches 7400 7400
=======================================
Hits 24240 24240
Misses 2931 2931
Partials 222 222 ☔ View full report in Codecov by Sentry. |
canova
approved these changes
May 30, 2024
canova
left a comment
Member
There was a problem hiding this comment.
LGTM. Looks like even though it's a major version upgrade, it's a non-breaking upgrade for most of the users. Works both on CI and locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ fake-indexeddb (5.0.2 → 6.0.0) · Repo · Changelog
Release Notes
6.0.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 10 commits:
6.0.0ChangelogUse DOMException rather than Error, since all supported versions of Node.js have that built-in now and that follows the IndexedDB spec better - closes #48Merge pull request #93 from bryan-codaio/fix-cached-set-immediateMerge pull request #99 from sjnho/issue-fix-98Upgrade dependenciesSwitch to pnpmUpdate CIFix issue #98: workaround to check date objectTypoDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands