Allow typing '?' in contenteditable elements without having the help menu pop in#5124
Merged
mstange merged 1 commit intoSep 12, 2024
Conversation
mstange
approved these changes
Sep 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5124 +/- ##
=======================================
Coverage 88.43% 88.43%
=======================================
Files 304 304
Lines 27580 27581 +1
Branches 7457 7458 +1
=======================================
+ Hits 24389 24390 +1
Misses 2963 2963
Partials 228 228 ☔ View full report in Codecov by Sentry. |
Contributor
|
Context: There are no contenteditable elements in the profiler UI at the moment, but there are add-ons which inject elements into the UI which might have them. Paul is working on https://padenot.github.io/fouineur/ which is where he encountered this. |
Merged
julienw
added a commit
that referenced
this pull request
Sep 16, 2024
[Florian Quèze] differential timestamp compression when serializing processed profiles (#5033) [joshuaobrien] Zip file viewer: omit profile extension if it is .json (#5079) [Paul Adenot] Allow typing '?' in `contenteditable` elements without having the help menu pop in (#5124) [Julien Wajsberg] Enable the Friulian locale (#5127) Thanks also to our localizers! fur: Fabio Tomat nl: simonmeulenbeek tr: Grk, Nazım Can Altınova
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.