Support profiling from the toolbox in Thunderbird Release#5135
Merged
julienw merged 1 commit intoSep 23, 2024
Conversation
canova
approved these changes
Sep 23, 2024
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
We were also checking for the version decimals plus a dot previously but I don't think that really makes a difference, right? Thanks for the fix!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5135 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 305 305
Lines 27716 27716
Branches 7514 7515 +1
=======================================
Hits 24501 24501
Misses 2981 2981
Partials 234 234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
julienw
changed the title
Thunderbird Releases doesn't include the Firefox/ string in its userAgent, therefore we neeed to match Thunderbird/ as well. See also the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1920387.
julienw
force-pushed
the
support-thunderbird-better
branch
from
0dfd9c0 to
50edb18
Compare
Contributor
Author
yeah I thought this wasn't really useful so I simplified it! |
Merged
julienw
added a commit
that referenced
this pull request
Sep 23, 2024
[Julien Wajsberg] Two optimizations for the marker chart (#5121) [Nazım Can Altınova] [Tab selector 5] Add a tab selector component and implement tab switching (#5093) [Julien Wajsberg] Support profiling from the toolbox in Thunderbird Release (#5135) [Richard Fine] Add a dedicated symbolication tool (#5123) [Julien Wajsberg] Export a tool to extract gecko logs from a profile (#4973) Shout-out to our localizers: de: Michael Köhler el: Jim Spentzos en-CA: chutten en-GB: Ian Neal es-CL: ravmn fr: Théo Chevalier fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy sv-SE: Andreas Pettersson uk: Lobodzets zh-CN: Olvcpr423 zh-TW: Pin-guang Chen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thunderbird Releases doesn't include the Firefox/ string in its userAgent, therefore we neeed to match Thunderbird/ as well.
See also the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1920387.
Fixes #5134
I checked locally that Thunderbird was working properly after this change.
For reference here is how I tried it:
openLinkIn("about:config")in the consoledevtools.performance.recording.ui-base-urlto point to the local development server