Add HTTP response status code in the profiler network tab#5297
Merged
Conversation
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5297 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 311 311
Lines 29653 29655 +2
Branches 8180 8181 +1
=======================================
+ Hits 25522 25524 +2
Misses 3550 3550
Partials 581 581 ☔ View full report in Codecov by Sentry. |
theskim
commented
Jan 9, 2025
| ); | ||
| }); | ||
|
|
||
| it('renders page information for pages with response status code', () => { |
Contributor
Author
There was a problem hiding this comment.
I limited the checks to one since we simply just displace responseStatus. Cases where responseStatus is absent are already covered by other test cases.
julienw
approved these changes
Jan 10, 2025
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this looks good to me.
I'd adjust the label just a little bit, see below!
|
|
||
| if (payload.responseStatus) { | ||
| details.push( | ||
| <TooltipDetail label="Response Status" key="Network-Response Status"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <TooltipDetail label="Response Status" key="Network-Response Status"> | |
| <TooltipDetail label="Response Status Code" key="Network-Response Status"> |
julienw
approved these changes
Jan 13, 2025
julienw
added a commit
that referenced
this pull request
Jan 15, 2025
Updates: [Nicolas Chevobbe] Adapt Keyboard shortcut dialog in High Contrast Mode. (#5245) [Nicolas Chevobbe] Fix sidebar-toggle in High Contrast Mode. (#5246) [Nicolas Chevobbe] Fix timeline selection overlay time / hover line in High Contrast Mode (#5247) [Zac Spitzer] fix broken link for processed profile format (#5267) [Greg Tatum] Update the memory allocation docs and add DHAT docs (#5270) [Markus Stange] Simplify some code related to thread CPU deltas (#5265) [Greg Tatum] Update dhat convertor to work better with valgrind (#5269) [Markus Stange] Rename UniqueStringArray to StringTable. (#5283) [Markus Stange] Use snapshot testing in the symbolicator CLI test. (#5284) [Markus Stange] Fix two confused upgraders which didn't expect to be run on the serialized format. (#5285) [Nicolas Chevobbe] Fix timelineSettingsHiddenTracks in High Contrast Mode. (#5250) [Julien Wajsberg] Fix some test and non-test warnings (#5294) [Nisarg Jhaveri] Support importing simpleperf trace files from Android Studio (#5212) [Sean Kim] Add HTTP response status code in the profiler network tab (#5297) [Markus Stange] Change StringTable API a bit. (#5286) [Markus Stange] Correctly declare imported simpleperf trace profiles to be of the current version. (#5312) [Markus Stange] Two small changes (#5313) [Nazım Can Altınova] Show sample tooltips on sample graph hover (#5298) Also thanks to our localizers: en-CA: chutten es-CL: ravmn es-CL: ravmn fr: Théo Chevalier ia: Melo46 ia: Melo46 sv-SE: Andreas Pettersson uk: Lobodzets zh-TW: Olvcpr423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.