Skip to content

Remove less used dependencies#5380

Merged
julienw merged 3 commits into
firefox-devtools:mainfrom
julienw:remove-less-used-dependencies
Feb 25, 2025
Merged

Remove less used dependencies#5380
julienw merged 3 commits into
firefox-devtools:mainfrom
julienw:remove-less-used-dependencies

Conversation

@julienw

@julienw julienw commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

This replaces some lesser used dependencies (the ones only used in some scripts we don't use every day) by running npx to install them on the fly. Note that Yarn v2 has yarn dlx but we don't have that with Yarn v1.

On my machine this reduces node_modules by 142 MB, that is more than 10%. Indeed a lot of the transitive dependencies were outdated and therefore duplicated from the more recent ones.

Also these transitive dependencies had security advisories. Good riddance :-)

@julienw julienw requested a review from canova February 24, 2025 18:15
@codecov

codecov Bot commented Feb 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.97%. Comparing base (e5d011b) to head (83e64fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5380   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files         312      312           
  Lines       30355    30355           
  Branches     8297     8297           
=======================================
  Hits        26098    26098           
  Misses       3660     3660           
  Partials      597      597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canova canova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I used them last time. Good to remove them!

@julienw julienw enabled auto-merge February 25, 2025 16:49
@julienw julienw merged commit 2eb2bf6 into firefox-devtools:main Feb 25, 2025
@julienw julienw mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants