Skip to content

Fix a type case inconsistency #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstange merged 1 commit into from
Aug 25, 2025
Merged

Fix a type case inconsistency #5569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/profile-logic/profile-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ import type {
CallTreeSummaryStrategy,
EventDelayInfo,
ThreadsKey,
resourceTypeEnum,
ResourceTypeEnum,
MarkerPayload,
Address,
AddressProof,
Expand Down Expand Up @@ -2822,7 +2822,7 @@ export function getThreadProcessDetails(
function _shouldShowBothOriginAndFileName(
fileName: string,
origin: string,
resourceType: resourceTypeEnum | null
resourceType: ResourceTypeEnum | null
): boolean {
// If the origin string is just a URL prefix that's part of the
// filename, it doesn't add any useful information, so only show
Expand Down
4 changes: 2 additions & 2 deletions src/types/profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export type IndexIntoLibs = number;
export type IndexIntoNativeSymbolTable = number;
export type IndexIntoCategoryList = number;
export type IndexIntoSubcategoryListForCategory = number;
export type resourceTypeEnum = number;
export type ResourceTypeEnum = number;
export type ThreadIndex = number;
// The Tid is most often a number. However in some cases such as merged profiles
// we could generate a string.
Expand Down Expand Up @@ -370,7 +370,7 @@ export type ResourceTable = {
lib: Array<IndexIntoLibs | null>;
name: Array<IndexIntoStringTable>;
host: Array<IndexIntoStringTable | null>;
type: resourceTypeEnum[];
type: ResourceTypeEnum[];
};

/**
Expand Down