Skip to content

Remove unused FilterNavigatorBar animations #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstange merged 1 commit into from
Sep 4, 2025
Merged

Remove unused FilterNavigatorBar animations #5591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 3 additions & 55 deletions src/components/shared/FilterNavigatorBar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
cursor: default;
user-select: none;

/* Note: no overflow: hidden so that we can see the exit animation for ranges */
/* Note: no overflow: hidden for historical reasons - we wanted to see
an animation for items at the end while they were fading out, but
we have removed this animation in the meantime */
Comment on lines +23 to +25

@canova canova Sep 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't know how useful this comment is now, I don't mind keeping it but maybe we can remove it all together.

}

.filterNavigatorBarItem {
Expand All @@ -40,9 +42,6 @@
in the forced colors media query. */
forced-color-adjust: none;
line-height: 24px;
transition:
opacity 250ms var(--animation-curve),
transform 250ms var(--animation-curve);
}

.filterNavigatorBarRootItem {
Expand Down Expand Up @@ -98,23 +97,12 @@
}

.filterNavigatorBarItem:not(.filterNavigatorBarLeafItem)::after {
animation: fadeIn 250ms var(--animation-curve);
background-image: var(--internal-separator-img);
background-position: -18px -12px;
background-repeat: no-repeat;
background-size: 24px 24px;
}

@keyframes fadeIn {
from {
opacity: 0;
}

to {
opacity: 1;
}
}

.filterNavigatorBarItem:not(
.filterNavigatorBarRootItem,
.filterNavigatorBarLeafItem
Expand Down Expand Up @@ -163,46 +151,6 @@
opacity: 0.65;
}

/* Animation */

.filterNavigatorBarUncommittedTransition-exit {
/* Because of the underlying transition library, this element is still here
* while the new "committed" element is created, which pushes it further
* right. By using display: none here, we prevent this bad effect. */
display: none;
}

.filterNavigatorBarTransition-enter {
color: inherit;

/* We use the same value as the uncommitted item.
* Note that the "uncommitted item" won't have this "enter" class when
* committing, because of how we insert it (it's not part of the same loop). */
opacity: 0.65;
}

.filterNavigatorBarTransition-enter.filterNavigatorBarTransition-enter-active {
color: var(--internal-selected-color);
opacity: 1;
}

.filterNavigatorBarTransition-exit {
opacity: 1;
}

.filterNavigatorBarTransition-exit.filterNavigatorBarTransition-exit-active {
opacity: 0;
transform: translateX(50%);
}

/* Do not animate the filter navigator bar items when user prefers reduced motion */
@media (prefers-reduced-motion) {
.filterNavigatorBarItem {
animation: none;
transition: none;
}
}

@media (forced-colors: active) {
.filterNavigatorBar {
--internal-background-color: ButtonFace;
Expand Down
54 changes: 17 additions & 37 deletions src/components/shared/FilterNavigatorBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import * as React from 'react';
import classNames from 'classnames';
import { CSSTransition, TransitionGroup } from 'react-transition-group';
import './FilterNavigatorBar.css';

type FilterNavigatorBarListItemProps = {
Expand Down Expand Up @@ -71,31 +70,21 @@ export class FilterNavigatorBar extends React.PureComponent<Props> {
const { className, items, selectedItem, uncommittedItem, onPop } =
this.props;

const transitions = items.map((item, i) => (
<CSSTransition
key={i}
classNames="filterNavigatorBarTransition"
timeout={250}
>
<FilterNavigatorBarListItem
index={i}
onClick={i === items.length - 1 && !uncommittedItem ? null : onPop}
isFirstItem={i === 0}
isLastItem={i === items.length - 1}
isSelectedItem={i === selectedItem}
>
{item}
</FilterNavigatorBarListItem>
</CSSTransition>
));

if (uncommittedItem) {
transitions.push(
<CSSTransition
key={items.length}
classNames="filterNavigatorBarUncommittedTransition"
timeout={0}
>
return (
<ol className={classNames('filterNavigatorBar', className)}>
{items.map((item, i) => (
<FilterNavigatorBarListItem
key={i}
index={i}
onClick={i === items.length - 1 && !uncommittedItem ? null : onPop}
isFirstItem={i === 0}
isLastItem={i === items.length - 1}
isSelectedItem={i === selectedItem}
>
{item}
</FilterNavigatorBarListItem>
))}
{uncommittedItem ? (
<FilterNavigatorBarListItem
index={items.length}
isFirstItem={false}
Expand All @@ -106,17 +95,8 @@ export class FilterNavigatorBar extends React.PureComponent<Props> {
>
{uncommittedItem}
</FilterNavigatorBarListItem>
</CSSTransition>
);
}

return (
<TransitionGroup
component="ol"
className={classNames('filterNavigatorBar', className)}
>
{transitions}
</TransitionGroup>
) : null}
</ol>
);
}
}
6 changes: 3 additions & 3 deletions src/test/components/__snapshots__/FilterNavigatorBar.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ exports[`app/ProfileFilterNavigator renders ProfileFilterNavigator properly 2`]
</button>
</li>
<li
class="filterNavigatorBarItem filterNavigatorBarSelectedItem filterNavigatorBarLeafItem filterNavigatorBarTransition-enter filterNavigatorBarTransition-enter-active"
class="filterNavigatorBarItem filterNavigatorBarSelectedItem filterNavigatorBarLeafItem"
>
<span
class="filterNavigatorBarItemContent"
Expand Down Expand Up @@ -70,7 +70,7 @@ exports[`app/ProfileFilterNavigator renders ProfileFilterNavigator properly 3`]
</button>
</li>
<li
class="filterNavigatorBarItem filterNavigatorBarSelectedItem filterNavigatorBarLeafItem filterNavigatorBarTransition-enter filterNavigatorBarTransition-enter-active"
class="filterNavigatorBarItem filterNavigatorBarSelectedItem filterNavigatorBarLeafItem"
>
<button
class="filterNavigatorBarItemContent"
Expand All @@ -80,7 +80,7 @@ exports[`app/ProfileFilterNavigator renders ProfileFilterNavigator properly 3`]
</button>
</li>
<li
class="filterNavigatorBarItem filterNavigatorBarUncommittedItem filterNavigatorBarLeafItem filterNavigatorBarUncommittedTransition-enter filterNavigatorBarUncommittedTransition-enter-active"
class="filterNavigatorBarItem filterNavigatorBarUncommittedItem filterNavigatorBarLeafItem"
title="100μs"
>
<span
Expand Down