-
Notifications
You must be signed in to change notification settings - Fork 479
Move compression and decompression to a worker #5597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| async function readableStreamToBuffer(stream) { | ||
| const reader = stream.getReader(); | ||
| const chunks = []; | ||
|
|
||
| try { | ||
| while (true) { | ||
| const { done, value } = await reader.read(); | ||
| if (done) break; | ||
| if (value) { | ||
| chunks.push(value); | ||
| } | ||
| } | ||
| } finally { | ||
| reader.releaseLock(); | ||
| } | ||
|
|
||
| // Calculate total length and combine chunks | ||
| const totalLength = chunks.reduce((sum, chunk) => sum + chunk.length, 0); | ||
| const result = new Uint8Array(totalLength); | ||
| let offset = 0; | ||
| for (const chunk of chunks) { | ||
| result.set(chunk, offset); | ||
| offset += chunk.length; | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| onmessage = async (e) => { | ||
| let data = e.data; | ||
| if (data.kind === 'compress') { | ||
| // Create a gzip compression stream | ||
| const compressionStream = new CompressionStream('gzip'); | ||
|
|
||
| // Write the data to the compression stream | ||
| const writer = compressionStream.writable.getWriter(); | ||
| writer.write(data.arrayData); | ||
| writer.close(); | ||
|
|
||
| // Read the compressed data back into a buffer | ||
| let result = await readableStreamToBuffer(compressionStream.readable); | ||
| postMessage(result, [result.buffer]); | ||
| } else if (data.kind === 'decompress') { | ||
| // Create a gzip compression stream | ||
| const decompressionStream = new DecompressionStream('gzip'); | ||
|
|
||
| // Write the data to the compression stream | ||
| const writer = decompressionStream.writable.getWriter(); | ||
| writer.write(data.arrayData); | ||
| writer.close(); | ||
|
|
||
| // Read the compressed data back into a buffer | ||
| let result = await readableStreamToBuffer(decompressionStream.readable); | ||
| postMessage(result, [result.buffer]); | ||
| } else { | ||
| throw new Error('unknown message'); | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you figure out that this part was needed? I just hit the same issue for
Responseand I was not having a good time figuring it out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I was skimming at the jest setup code and kind of just got lucky with a guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, fair enough!