fix: resolve nested link in project cards #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem: On project cards with open issues, the "Go to Project" button was unresponsive. This was caused by the entire card being wrapped in an tag, while the IssueList component also contained tags. Browsers do not support nested links, causing the HTML to break.
The Fix: I refactored ProjectCard.astro to remove the outer wrapper. I moved the project link specifically to the Header and the "Go to Project" button separately. This ensures valid HTML structure and allows the button to work even when issues are displayed.
Testing: Verified locally that:
The "Go to Project" button works on cards with issues.
The header remains clickable.
The issue links themselves still function correctly.