Skip to content
This repository was archived by the owner on Dec 7, 2022. It is now read-only.

[SPM] Add support for swift package manager#35

Open
havocked wants to merge 3 commits intofiskaly:masterfrom
havocked:swift-package-support
Open

[SPM] Add support for swift package manager#35
havocked wants to merge 3 commits intofiskaly:masterfrom
havocked:swift-package-support

Conversation

@havocked
Copy link

@havocked havocked commented Nov 25, 2020

Feature

Swift Package support

Motivation

We would like to add FiskalySDK framework with Swift Package Manager.

Pitch

Swift Package is getting increasingly more attention by developers.
This PR shows that it's possible add this support without too much efforts and can benefits everyone!

What's going on?

How to improve this PR

  • We can modify to generateXCFramework.sh to generate a .zip file like so you can upload it and have a reference in the cloud
  • Modify Package.swift to point at the uploaded .zip file url
  • Remove the .xctframework

Notes:

In FiskalySDK.xcodeproj/project.pbxproj, I've excluded arm64 architecture for iphone simulator in order to build, because I'm using XCode Version 12.2 (12B45b)

Debug/Release config:~ ~"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = arm64;
I had to remove this flag in order to pass CI

@havocked havocked mentioned this pull request Dec 1, 2020
@havocked
Copy link
Author

For now it works with XCode 11.3 for testing. But if using, later XCode version (12.2 for ex.), building will fail because of missing build settings: EXCLUDE_ARCHS -> ARM64

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants