Merged
Conversation
Collaborator
Author
|
Re-ran benchmarks with Rust 1.73.0-beta, which includes an LLVM upgrade: Expand for benchmarks table
Old version got slower, new version gets faster. Neat. |
592dedf to
ab6fd0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizes the standard encoding, plus adds support for using the
faster-hexcrate for SIMD-accelerated encoding.Expand for benchmarks table
It's worth noting at least 10-16ns of those benchmarks seems to be spent on non-encoding things. In fact it was made worse when I upgraded to Rust 1.72.0 today, but only in terms of that base offset.
I'm not super happy about the
unsafeusage here, but when mixing the fmt precision in like that LLVM has a harder time reasoning with it.