quick-xml demangling#424
Closed
cjgatto wants to merge 1 commit into
Closed
Conversation
djc
reviewed
Jan 6, 2026
Contributor
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Here's some early feedback. I'll likely have more when this is addressed.
| } | ||
| } | ||
|
|
||
| fn demangle_stream<R: BufRead, W: Write>(input: &mut R, output: &mut W) -> std::io::Result<()> { |
Contributor
There was a problem hiding this comment.
We should only do this on macOS when the xctrace backend is used.
| Ok(()) | ||
| } | ||
|
|
||
| fn demangle_element( |
| Ok(new_element) | ||
| } | ||
|
|
||
| fn demangle_attribute(attribute: &mut quick_xml::events::attributes::Attribute) { |
Contributor
|
I have made the revisions cjgatto#1 according to the feedback. I hope this issue can be fixed quickly. |
Merged
Contributor
|
Merged via Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered same "invalid xml from xctrace" detailed at #421
Stole the fix f82bc92