Skip to content

fix(profiles): inline workspace styles - #63

Merged
moshloop merged 7 commits into
mainfrom
fix/profiles-inline-workspace-styles
Aug 12, 2026
Merged

fix(profiles): inline workspace styles#63
moshloop merged 7 commits into
mainfrom
fix/profiles-inline-workspace-styles

Conversation

@moshloop

Copy link
Copy Markdown
Member

What

  • Inline profile workspace sizing and scrolling styles with Tailwind utilities.
  • Add regression coverage for query output, sorting, and column filters.

Why

  • Ensure published consumers receive the layout styles without a separate CSS asset.

… workspaces

Add reusable query browsing, sampling, and OpenSearch query-building flows for profile creation and editing. Introduce a schema-configured profile editor route with column management, previews, JSONPath selection, YAML editing, parameter validation, and row-limit controls. Cover the new models, components, integrations, and authoring workflows with focused tests and Storybook coverage.
Add `x-array-display: "cards"` for titled, always-expanded object-array editors using the existing `x-item` summary configuration. Also keep inline array items aligned with the form's label/value grid and share item-row controls across displays.
Expose profile authoring and query browsing through reusable package/demo surfaces, with Storybook and kitchen-sink coverage. Preserve provider error diagnostics through query execution and let users copy complete diagnostic reports without expanding details.
Move modal sizing and scrolling constraints into Tailwind utilities so published consumers receive the layout styles without importing a separate CSS asset. Add regression coverage for query output, sorting, and column-filter behavior.
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 121 files, which is 21 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62ab2784-52dd-416b-9ed5-a21889bd315f

📥 Commits

Reviewing files that changed from the base of the PR and between f357471 and abd8a9c.

📒 Files selected for processing (121)
  • apps/kitchen-sink/src/demo-catalog.tsx
  • apps/kitchen-sink/src/demos/ProfilesDemo.tsx
  • apps/kitchen-sink/src/demos/QueryBrowserDemo.tsx
  • apps/kitchen-sink/src/demos/examples.test.tsx
  • apps/kitchen-sink/tsconfig.json
  • apps/kitchen-sink/vite.config.ts
  • apps/storybook/.storybook/main.ts
  • packages/ui/package.json
  • packages/ui/src/components.ts
  • packages/ui/src/components/ErrorWrapper.test.tsx
  • packages/ui/src/components/ErrorWrapper.tsx
  • packages/ui/src/components/JsonSchemaForm.stories.tsx
  • packages/ui/src/components/UnitStepControls.tsx
  • packages/ui/src/components/json-schema-form-accordion-array.tsx
  • packages/ui/src/components/json-schema-form-array-inline.test.tsx
  • packages/ui/src/components/json-schema-form-array.tsx
  • packages/ui/src/components/json-schema-form-cards-array.test.tsx
  • packages/ui/src/components/json-schema-form-cards-array.tsx
  • packages/ui/src/components/json-schema-form-item-row.tsx
  • packages/ui/src/components/json-schema-form-render.tsx
  • packages/ui/src/components/json-schema-form-resolve.ts
  • packages/ui/src/components/json-schema-form-types.ts
  • packages/ui/src/components/unit-form-extension.test.tsx
  • packages/ui/src/components/unit-form-extension.tsx
  • packages/ui/src/data/DataTable.stories.tsx
  • packages/ui/src/data/diagnostics/ErrorDetails.test.tsx
  • packages/ui/src/data/diagnostics/ErrorDetails.tsx
  • packages/ui/src/data/diagnostics/error-diagnostics.ts
  • packages/ui/src/data/query-browser/QueryBrowser.paging.test.tsx
  • packages/ui/src/data/query-browser/QueryBrowser.stories.tsx
  • packages/ui/src/data/query-browser/QueryBrowser.tsx
  • packages/ui/src/data/query-browser/QueryBrowser.types.ts
  • packages/ui/src/lib/string.test.ts
  • packages/ui/src/lib/string.ts
  • packages/ui/src/profiles.ts
  • packages/ui/src/profiles/.widen.py
  • packages/ui/src/profiles/ProfileEditor.stories.tsx
  • packages/ui/src/profiles/catalogTree.tsx
  • packages/ui/src/profiles/connectionBrowserModel.test.ts
  • packages/ui/src/profiles/connectionBrowserModel.ts
  • packages/ui/src/profiles/connectionQueryWorkspace.test.tsx
  • packages/ui/src/profiles/connectionQueryWorkspace.tsx
  • packages/ui/src/profiles/connectionQueryWorkspaceModel.ts
  • packages/ui/src/profiles/esFieldValues.test.ts
  • packages/ui/src/profiles/esFieldValues.ts
  • packages/ui/src/profiles/esParamMappingModel.test.ts
  • packages/ui/src/profiles/esParamMappingModel.ts
  • packages/ui/src/profiles/esParamMappingPill.tsx
  • packages/ui/src/profiles/esParamOperandExtension.tsx
  • packages/ui/src/profiles/esQueryBuilder.test.tsx
  • packages/ui/src/profiles/esQueryBuilder.tsx
  • packages/ui/src/profiles/esQueryBuilderExtension.tsx
  • packages/ui/src/profiles/esQueryBuilderForm.ts
  • packages/ui/src/profiles/esQueryBuilderModel.test.ts
  • packages/ui/src/profiles/esQueryBuilderModel.ts
  • packages/ui/src/profiles/esQueryClauseGroup.test.tsx
  • packages/ui/src/profiles/esQueryClauseGroup.tsx
  • packages/ui/src/profiles/esQueryCompile.ts
  • packages/ui/src/profiles/esQueryConditionRow.test.tsx
  • packages/ui/src/profiles/esQueryConditionRow.tsx
  • packages/ui/src/profiles/esQueryGroupModel.ts
  • packages/ui/src/profiles/esQueryOccur.ts
  • packages/ui/src/profiles/esQueryOperandEditors.tsx
  • packages/ui/src/profiles/esQueryOperandModel.test.ts
  • packages/ui/src/profiles/esQueryOperandModel.ts
  • packages/ui/src/profiles/esQueryOperators.test.ts
  • packages/ui/src/profiles/esQueryOperators.ts
  • packages/ui/src/profiles/esQueryOutputEditor.tsx
  • packages/ui/src/profiles/esQueryOutputEditors.test.tsx
  • packages/ui/src/profiles/esQueryOutputModel.ts
  • packages/ui/src/profiles/esQueryPreview.tsx
  • packages/ui/src/profiles/esQuerySortEditor.tsx
  • packages/ui/src/profiles/esQuerySortModel.ts
  • packages/ui/src/profiles/esValueCombobox.test.tsx
  • packages/ui/src/profiles/esValueCombobox.tsx
  • packages/ui/src/profiles/jsonPathSample.ts
  • packages/ui/src/profiles/jsonPathSampleRow.test.ts
  • packages/ui/src/profiles/jsonPathSampleRow.tsx
  • packages/ui/src/profiles/profileApi.ts
  • packages/ui/src/profiles/profileBuilder.test.ts
  • packages/ui/src/profiles/profileBuilder.tsx
  • packages/ui/src/profiles/profileBuilderExtension.tsx
  • packages/ui/src/profiles/profileBuilderWorkspace.tsx
  • packages/ui/src/profiles/profileColumnFilter.test.ts
  • packages/ui/src/profiles/profileColumnModel.ts
  • packages/ui/src/profiles/profileColumnPicker.tsx
  • packages/ui/src/profiles/profileEditor.tsx
  • packages/ui/src/profiles/profileEditorModel.test.ts
  • packages/ui/src/profiles/profileEditorModel.ts
  • packages/ui/src/profiles/profileEditorPreview.tsx
  • packages/ui/src/profiles/profileEditorRail.tsx
  • packages/ui/src/profiles/profileEditorRaw.test.tsx
  • packages/ui/src/profiles/profileEditorRaw.tsx
  • packages/ui/src/profiles/profileEditorRoutes.ts
  • packages/ui/src/profiles/profileEditorSections.tsx
  • packages/ui/src/profiles/profileFieldEditor.tsx
  • packages/ui/src/profiles/profileFieldGrid.tsx
  • packages/ui/src/profiles/profileFieldManager.tsx
  • packages/ui/src/profiles/profileFieldState.test.tsx
  • packages/ui/src/profiles/profileFieldState.ts
  • packages/ui/src/profiles/profileFieldTypes.ts
  • packages/ui/src/profiles/profileParamModel.test.ts
  • packages/ui/src/profiles/profileParamModel.ts
  • packages/ui/src/profiles/profileSamplePayload.test.ts
  • packages/ui/src/profiles/profileSamplePayload.ts
  • packages/ui/src/profiles/profileWizard.test.tsx
  • packages/ui/src/profiles/profileWizard.tsx
  • packages/ui/src/profiles/profileWizardHelp.ts
  • packages/ui/src/profiles/profileWizardModel.ts
  • packages/ui/src/profiles/profileWizardQueryStep.test.tsx
  • packages/ui/src/profiles/profileWizardQueryStep.tsx
  • packages/ui/src/profiles/profileWizardSteps.tsx
  • packages/ui/src/profiles/profileYaml.ts
  • packages/ui/src/profiles/prometheusResults.tsx
  • packages/ui/src/profiles/queryRowLimits.test.tsx
  • packages/ui/src/profiles/queryRowLimits.tsx
  • packages/ui/src/profiles/queryRowLimitsModel.ts
  • packages/ui/src/profiles/queryTargetPicker.test.tsx
  • packages/ui/src/profiles/queryTargetPicker.tsx
  • packages/ui/src/profiles/testSchema.ts
  • packages/ui/vite.config.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread packages/ui/src/profiles/profileApi.ts Fixed
Comment thread packages/ui/src/profiles/profileEditorModel.ts Fixed
Comment thread packages/ui/src/profiles/profileYaml.ts Fixed
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-12 05:38 UTC

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Gavel summary

Source Pass Fail Skip Duration
./apps/kitchen-sink 6 0 0 1.8s
./apps/playground 89 0 0 366ms
./apps/storybook 652 0 0 1m29s
./e2e 4 0 0 1m32s
./packages/ui 2983 0 0 2m55s
lint: betterleaks 0 0 1 -
lint: tsc 1 0 0 257ms

Totals: 3735 passed · 0 failed · 1 skipped · 5m57s

View full results

Render count and byte fields in human-readable units while preserving canonical values for API requests.
Add stepping controls and read-only handling for unit-aware schema fields.
Centralize profile sampling payload construction and fail fast when a provider is missing.
Use linear boundary scans for profile slugs and API paths to avoid pathological regex behavior without changing normalized output.
Distinguish page-level error report copying from detailed error copying for unambiguous assistive-technology actions.
Prebundle CodeMirror dependencies in Storybook for consistent editor story resolution.

Claude-Session-Id: be60ad79-f082-49b3-8fee-9a584b3c646f
Claude-Session-Id: be60ad79-f082-49b3-8fee-9a584b3c646f
@moshloop
moshloop merged commit 3d52e20 into main Aug 12, 2026
10 checks passed
@moshloop
moshloop deleted the fix/profiles-inline-workspace-styles branch August 12, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants