docs(hooks): restore and update hooks examples in file-formats.md#4
Closed
flanny7 wants to merge 6 commits into
Closed
docs(hooks): restore and update hooks examples in file-formats.md#4flanny7 wants to merge 6 commits into
flanny7 wants to merge 6 commits into
Conversation
VSCode Copilot Chat requires agent files to have the .agent.md extension to be recognized and loaded. Previously, rulesync generated files as .md which caused them to be silently ignored by Copilot. Fixes dyoshikawa#1432 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Change Copilot filePattern from "*.md" to "*.agent.md" so deletion (rulesync generate --delete) correctly finds and removes stale files - Add fromAgentMdFilePath() to convert .agent.md back to .md in toRulesyncSubagent() for correct import paths - Update subagents-processor test to use .agent.md file names Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Silently appending .agent.md to a non-.md path (e.g. planner.txt) would produce malformed filenames like planner.txt.agent.md that Copilot Chat would never load. Fail fast with a clear error instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The hooks Example section was displaced when the .copilot/mcp-config.json section was inserted in commit 73abcff, splitting the hooks section in two. The override keys description and Example ended up under the copilot section. Changes: - Move override keys paragraph and hooks Example back into .rulesync/hooks.json section - Add Hook definition fields table (command, type, timeout, matcher, prompt, loop_limit, name, description) - Add missing tool event lists: Kilo, Factory Droid, DeepAgents, Codex CLI - Update override keys list to include all 9 supported tools - Update hooks Example to be comprehensive: show all HookDefinitionSchema fields and tool-specific override sections for all supported tools Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ut transformations table Remove tool-specific override sections from Example that only showed regular events. Keep claudecode override only (worktreeCreate is a unique event). Add Tool-specific output transformations table documenting unique output keys/behavior for each tool (Copilot bash/powershell, Gemini matcher grouping, DeepAgents array command format, etc.). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a cross-reference table showing which canonical hook definition fields are supported or dropped by each tool. Includes footnotes for partial support (e.g. command-only type, hardcoded timeout, worktree matcher exceptions). Based on both implementation code and official tool docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
flanny7
pushed a commit
that referenced
this pull request
Apr 22, 2026
- #1: use static import for resetDeprecationWarningForTests in tests - #2: document why mutual-exclusivity is runtime-enforced, not a discriminated union - dyoshikawa#3: stop emitting the deprecation warning from the Config constructor; the ConfigResolver is now the single emission point - #4: cache validated ToolTarget[] for object-form targets in the constructor so getTargets() no longer rebuilds the ALL_TOOL_TARGETS set per call - #5: fix misleading schema comment that claimed unknown-target warnings (the runtime path actually throws) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
flanny7
pushed a commit
that referenced
this pull request
Apr 22, 2026
Address Round 2 review findings for PR dyoshikawa#1526: - HIGH-R2-#1: guard the stale-file cleanup loop in apm-install.ts against path traversal. Attacker-controlled deployed_files entries with ".." segments or absolute paths are now rejected by shape and via checkPathTraversal, with a warn log per offending entry, so a hostile lockfile cannot drive arbitrary removeFile calls. - MID-R2-#2: make lockfile ordering deterministic for failed deps. The per-dep worker now returns the preserved prior entry via its result object, and the sequential post-loop pushes successes or preserved entries strictly in manifest order, not in promise-completion order. - MID-R2-dyoshikawa#3: preserve top-level loose fields (mcp_servers and any looseObject extras) across lockfile rewrites by carrying forward existingLock through createEmptyApmLock. - MID-R2-#4: relax the content_hash schema to accept arbitrary strings on parse so a lockfile produced by the upstream apm CLI does not break readApmLock. The --frozen integrity check now only compares hashes whose shape matches RULESYNC_CONTENT_HASH_REGEX and skips comparison otherwise (commit SHA pin still enforces integrity). Tests added for each finding, including a two-dep ordering regression and a frozen-mode interop check with a legacy content_hash value. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
flanny7
pushed a commit
that referenced
this pull request
May 11, 2026
…ode/cline/qwencode Addresses 18 reviewer findings raised on PR dyoshikawa#1338. Highlights: - #1 (critical): AugmentCode non-bash categories now fail-closed. A single deny rule in `read`/`edit`/`write`/`webfetch`/`websearch` collapses the whole tool to a catch-all `deny` entry; non-`*` allow/ask patterns are dropped with an aggregated warning instead of being silently downgraded to a catch-all `allow` that would shadow a deny. - #2 (high): `toolPermissions` are sorted to make AugmentCode's first-match-wins evaluation safe — entries with `shellInputRegex` come before catch-alls, longer regex first, with deny < ask-user < allow as the tiebreaker. - #5 (mid): existing `launch-process` deny entries are preserved across regeneration so a user-added shell deny rule cannot be silently downgraded; non-deny launch-process entries are still owned by rulesync. - dyoshikawa#3 (mid): Qwencode generation uses `readFileContentOrNull` (no `readOrInitializeFileContent`) so dry-run does not create the `.qwen/` directory. - #4 (mid): Kilo schema parsing is deferred and respects `params.validate`, so `forDeletion` and dry-run construction never throw on permissive input. - #7, dyoshikawa#16 (mid/low): Cline drops non-bash / ask rules at `logger.error` level (rather than warn) and surfaces a defensive warn on allow/deny pattern collisions. - #8, #13 (mid/low): Qwencode pattern parser uses the LAST `)` so nested parentheses (e.g. `Bash(echo (a))`) round-trip; malformed entries warn and fall back to `*`. - #9 (low): Augment non-bash warnings are aggregated once per category. - #11 (low): Kilo's wholesale-replace of the `permission` object is documented in `docs/reference/file-formats.md`. - #10, #6 (low): glob→regex behaviour and round-trip caveats are documented. - #14 (low): `mergedPermissions` is typed as `{ allow?: string[]; ask?: string[]; deny?: string[]; [k: string]: unknown }`. - #15 (low): redundant Qwencode global-mode equivalence assert removed. - dyoshikawa#17 (low): `permissions-processor.test.ts` gains `loadToolFiles` cases for AugmentCode, Cline, Kilo, and Qwencode. Deferred: - #12 (kilo home-mock migration): the existing kilo global-mode test already passes `outputRoot` directly and does not reach `getHomeDirectory()`, so introducing the home-mock pattern adds only ceremony without coverage. - dyoshikawa#18 (tool-name-mapping helper extraction): postponed to keep this fix focused and to avoid touching files outside the permissions feature. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
flanny7
pushed a commit
that referenced
this pull request
May 11, 2026
- #1 (mid): augmentcode-permissions sort the COMBINED [generated, preserved] entries so a preserved launch-process deny cannot be shadowed by a generated catch-all allow/ask under first-match-wins. Adds regression test. - #2 (low): sortAugmentEntries applies fail-closed type priority (deny < ask-user < allow) BEFORE the regex-length heuristic for has-regex entries. Heuristic limits documented in code. - dyoshikawa#3 (low): cline-permissions downgrades translation-loss logs from logger.error to a single aggregated logger.warn per call (project convention; CI gates that treat error lines as failures no longer trip). - #4 (low): documents in docs/reference/file-formats.md (and synced skills/rulesync/file-formats.md) that Cline allow/deny arrays are owned by rulesync entirely (no preservation), in contrast to Qwen Code and AugmentCode. - #5 (low): qwencode-permissions forwards a logger to parseQwenPermissionEntry from both call sites (preservation filter and convertQwenToRulesyncPermissions) so the malformed-entry warnings are no longer dead code in production. - #6 (low): qwencode-permissions.test extends the nested-paren round-trip test to cover sequential parens (Bash(grep (foo) | wc (-l))) and multi-nesting (Bash(echo ((deep)))).
flanny7
pushed a commit
that referenced
this pull request
May 11, 2026
…structors Address review findings on PR dyoshikawa#1589: - #1 (mid): Wire `validate()` into the constructors of AugmentcodePermissions, ClinePermissions, and QwencodePermissions so that `fromFile({ validate: true })` actually rejects malformed input. Previously the validate() method existed but was never invoked at construction time, so callers reading `validate: true` falsely assumed validation had run. Mirrors the RulesyncPermissions pattern. - dyoshikawa#3 (low): Drop PR-internal label `(Finding F)` from the describe title in augmentcode-permissions.test.ts since it is meaningless after merge. - #4 (low): Add a co-located inner `afterEach` that restores the warnSpy on ConsoleLogger.prototype, instead of relying on the outer describe's vi.restoreAllMocks(). Keeps the cleanup next to the spy so future refactors cannot silently leak the prototype-level spy across other test files. Adds three constructor-level rejection tests per class (malformed JSON, schema violation, and a validate: false escape hatch) so future regressions are caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes dyoshikawa#3
.rulesync/hooks.jsonsection (displaced since73abcff0when.copilot/mcp-config.jsonwas inserted mid-section)HookDefinitionSchemafieldsTest plan
pnpm cicheck:contentpasses (spelling, secrets)pnpm docs:build/reference/file-formats.htmlfor correct structuresrc/types/hooks.tsconstantsHooksConfigSchemainsrc/types/hooks.ts🤖 Generated with Claude Code