Shell scripts should use #!/usr/bin/env bash and flake.nix should add all needed tools to development shell - #130
Merged
Merged
Conversation
… all needed tool to development shell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has some changes i needed to get this to build locally on nixos without lima.
The shell scripts in this repo assume bash is located at
/bin/bashwhich isn't always the case. This PR switches them to use/usr/bin/env bashwhich is more universal.This also adds some basic tools to the
flake.nixdeveloper shell which are needed by the build:bash,curl,gitandjq.