Fix .Numberize to be RFC 8259 compliant and not throw on Bulgarian systems.#1
Open
petersvp wants to merge 1 commit into
Open
Fix .Numberize to be RFC 8259 compliant and not throw on Bulgarian systems.#1petersvp wants to merge 1 commit into
petersvp wants to merge 1 commit into
Conversation
…read Culture, and on some non-english systems, e.g. in Bulgarian, float.Parse excepts a comma instead of a dot while parsing. Which causes bugs and exceptions, especially a "NotImplementedException" when passing the string "1.234" while it expects "1,234". I've fixed the library to explicitly pass InvariantCulture to these parse methods, respecting RFC 8259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C# has context of thread Globalization setting, the Thread Culture, and on some non-english systems, e.g. in Bulgarian, float.Parse excepts a comma instead of a dot while parsing. Which causes bugs and exceptions, especially a "NotImplementedException" when passing the string "1.234" while it expects "1,234".
I've fixed the library to explicitly pass InvariantCulture to these parse methods, respecting RFC 8259, forcing JSON-compliance and no "NotImplementedException" being thrown.