Skip to content

Conversation

@taylorhadden
Copy link
Collaborator

No description provided.

@flathubbot
Copy link

🚧 Test build enqueued.

@taylorhadden taylorhadden changed the title Bump version number Beta 5 Jun 1, 2025
@flathubbot
Copy link

🚧 Started test build.

@flathubbot
Copy link

🚧 Test build failed.

@taylorhadden
Copy link
Collaborator Author

@k8ieone, any idea on how to resolve this? I think the offending vscode-textmate dependency is pulled in at build time rather than being explicit…

@k8ieone
Copy link
Collaborator

k8ieone commented Jun 1, 2025

Right, I think it should just be enough to regenerate generated-sources.json.

I can take a look at it tomorrow.

@k8ieone
Copy link
Collaborator

k8ieone commented Jun 1, 2025

If it is not being pulled as a dependency of another package we'll have to add it manually. Bit of an annoyance, but it should be fine.

@flathubbot
Copy link

🚧 Test build enqueued.

@flathubbot
Copy link

🚧 Started test build.

@k8ieone
Copy link
Collaborator

k8ieone commented Jun 27, 2025

Sorry for not looking into this sooner, extremely busy with life.

Getting the new generated sources wasn't trivial, first I kept getting this

flatpak-node-generator npm package-lock.json
Reading packages from lockfiles...
Traceback (most recent call last):
  File "/home/k8ie/.local/bin/flatpak-node-generator", line 8, in <module>
    sys.exit(main())
             ~~~~^^
  File "/home/k8ie/.local/share/pipx/venvs/flatpak-node-generator/lib/python3.13/site-packages/flatpak_node_generator/main.py", line 277, in main
    asyncio.run(_async_main())
    ~~~~~~~~~~~^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/asyncio/runners.py", line 195, in run
    return runner.run(main)
           ~~~~~~~~~~^^^^^^
  File "/usr/lib/python3.13/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/usr/lib/python3.13/asyncio/base_events.py", line 719, in run_until_complete
    return future.result()
           ~~~~~~~~~~~~~^^
  File "/home/k8ie/.local/share/pipx/venvs/flatpak-node-generator/lib/python3.13/site-packages/flatpak_node_generator/main.py", line 198, in _async_main
    packages.update(lockfile_provider.process_lockfile(lockfile))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/k8ie/.local/share/pipx/venvs/flatpak-node-generator/lib/python3.13/site-packages/flatpak_node_generator/providers/npm.py", line 166, in process_lockfile
    yield from self._process_packages_v2(lockfile, data)
  File "/home/k8ie/.local/share/pipx/venvs/flatpak-node-generator/lib/python3.13/site-packages/flatpak_node_generator/providers/npm.py", line 133, in _process_packages_v2
    raise NotImplementedError(
    ...<2 lines>...
    )
NotImplementedError: Git sources in lockfile v2 format are not supported yet (package node_modules/@electron/node-gyp in package-lock.json)

which I worked around by using the code from flatpak/flatpak-builder-tools#382

Then I started getting an unknown Playwright browser error which I solved with the workaround described in flatpak/flatpak-builder-tools#438

@k8ieone
Copy link
Collaborator

k8ieone commented Jun 27, 2025

I'll go ahead and merge this and prep a PR for the 0.9.0 release version.

@k8ieone k8ieone merged commit c1f9c60 into beta Jun 27, 2025
1 check passed
@k8ieone k8ieone deleted the beta5 branch June 27, 2025 16:43
@flathubbot
Copy link

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/194339/io.github.suchnsuch.Tangent.flatpakref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants