Refactor the node generator into a proper Python package & add tests #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
YAPF isn't used very often anymore in favor of Black...but I'm *very* tied to my single quotes... Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Not all the errors are fixed yet, but some of the code is going to be removed shortly anyway. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
gasinvein
reviewed
Jun 16, 2022
| build-commands: | ||
| # Have Yarn use the offline mirror. | ||
| - 'HOME=$PWD yarn config --offline set yarn-offline-mirror $FLATPAK_BUILDER_BUILDDIR/flatpak-node/yarn-mirror' | ||
| - HOME=$PWD yarn config --offline set yarn-offline-mirror $FLATPAK_BUILDER_BUILDDIR/flatpak-node/yarn-mirror |
Member
There was a problem hiding this comment.
This is rather hackish, I'd rather suggest adding a separate .yarnrc source instead:
sources:
...
- type: inline
contents: |
yarn-offline-mirror /run/build/electron-webpack-quick-start/flatpak-node/yarn-mirror
dest-filename: .yarnrc
gasinvein
approved these changes
Jun 16, 2022
Member
gasinvein
left a comment
gasinvein
left a comment
There was a problem hiding this comment.
I didn't really look into the newly-added tests, but overall this looks cool!
Re-committed by refi64 w/ some minor fixes, notes: Original commit at #287, I made some changes to match npm's behavior a bit more closely. Context: > Hahaha, so after hitting this locally, I've come to believe this > actually changed in the npm registry, and dists that formerly returned > the sha1 they were uploaded with now return a newly computed sha512. I > think the previous behavior I followed was also changed in npm/pacote > at some point too.
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Also adds another useful tool shell script to be able to generate the lockfiles & examine the npm/yarn caches. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Also adds tests on Git repositories specifically. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Fixes #278. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
This was referenced Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and also fix some bugs (includes slightly-tweaked #287). But bugs don't matter anyway, because THE CODE IS PRETTY!
Rationale:
pipx install flatpak-node-generator, and we can actually safely add dependencies without breaking everything or requiring manual venv management.The main still-outstanding things are:
But for now, this is a good start!
(If I sound slightly hyper after spending several hours fighting with npm, it is because I am indeed hyper after spending several hours fighting with npm.)