Updated RawEditorStateTextInputClientMixin to implement DeltaTextInputClient

[Amir-P]

Fixes #34 and #31 .

Thanks to @cgestes for testing and finding selection issue.

[Amir-P]

It's still draft but can you test and provide feedback on it? @amantoux

[amantoux]

@Amir-P

[codecov]

Codecov Report

Merging #35 (ac27990) into master (68ae54f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   75.45%   75.49%   +0.04%     
==========================================
  Files          57       57              
  Lines        8644     8644              
==========================================
+ Hits         6522     6526       +4     
+ Misses       2122     2118       -4     

Impacted Files	Coverage Δ
...her/lib/src/widgets/editor_input_client_mixin.dart	47.15% <100.00%> (+3.25%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[cgestes]

what's the status of this PR? (have been using daily, works good :))

[amantoux]

what's the status of this PR? (have been using daily, works good :))

There's a problem in Flutter web
Hitting suppr, the deletedRange is the same as a del when it should be TextRange(start:deletedRange.start + 1, end: deletedRange.end + 1)

@cgestes no issues on web?

Note: flutter-team-archive/engine#28527

[cgestes]

didn't try on the web !

dang!

[amantoux]

flutter/samples#1424

[cgestes]

thanks to @amantoux for pointing out the bugs in flutter/samples.

they made a PR to fix the web issue. flutter/samples#1458

time to go forward?

[amantoux]

Don't we need flutter-team-archive/engine#36616?

Beside, unfortunately (or fortunately depends on the point of view) I'm using this in production, so need to wait for it to land in a release

[Amir-P]

Looks like the issue with deltas for Web is fixed on 3.7 stable. @amantoux @cgestes

[amantoux]

It needs a rebase I guess

[amantoux]

@Amir-P we'll upgrade to Flutter 3.7 with #89
Can you rebase once this is done?
btw this PR is still draft, is it still intended?

[Amir-P]

There were problems with history tests using old text editing API. I've updated them and now I think we're good to go. Please review. @amantoux

[amantoux]

@Amir-P, overall it look good to me
I just have concerns about the dependency on Mocktail package (even if only a dev dependency)
It doesn't seem to be maintained (no code update for the last year almost)

(as discussed, it is reliable)