-
Notifications
You must be signed in to change notification settings - Fork 9
Change default size to be None. If mathematically needed, Users need to specify it #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FBumann
merged 21 commits into
feature/solution-storage-change
from
feature/solution-storage-change+default-size
Dec 13, 2025
Merged
Changes from 12 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5cd1733
Change default size to None. Raise if not set and Status is used
FBumann 7d0d715
Make maximum size mandatory (or fixed size). Update tests accordingly
FBumann 9e9b0a1
Adding maximum sizes for FLows which get Status variables (also if on…
FBumann 0208ca5
Update more tests
FBumann c6990dd
BUGFIX: Minimum or foixed size in storages
FBumann 1b90714
Merge remote-tracking branch 'origin/feature/solution-storage-change'…
FBumann 816297c
Added validation:
FBumann 22a299f
In flixopt/elements.py - Flow._plausibility_checks():
FBumann b46f045
Added more validations
FBumann b2b65a5
Fix test
FBumann d2a7ceb
Merge branch 'feature/solution-storage-change' into feature/solution-…
FBumann 8edd7c2
Fix tests to specify size if needed
FBumann bd9c1d0
Improve check verbosity
FBumann 421125f
Fix type hint
FBumann 16d2d24
Improve conftest.py
FBumann 5faa457
Merge branch 'feature/solution-storage-change' into feature/solution-…
FBumann 22a8bb1
Merge branch 'feature/solution-storage-change' into feature/solution-…
FBumann eb62cb6
Merge branch 'feature/solution-storage-change' into feature/solution-…
FBumann a01c2f9
Merge branch 'feature/solution-storage-change' into feature/solution-…
FBumann 8d62ab3
Merge branch 'feature/solution-storage-change' into feature/solution-…
FBumann 28ee53f
Merge remote-tracking branch 'origin/feature/solution-storage-change'…
FBumann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: initial_charge_state feasibility checks use inverted min/max capacity multipliers (will raise incorrectly).
🤖 Prompt for AI Agents