update pricing.yaml files#6
Conversation
📝 WalkthroughWalkthroughConverted per-product pricing from a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I'll do this for the other examples too... |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pay-as-you-go/pricing.yaml (1)
1-75: Schema change introduces incompatibility with Flowglad's documented format.The restructuring changes products from using
prices:(array) toprice:(object), but Flowglad's official documentation specifies the expected schema usesprices:(plural, array). Additionally, this creates inconsistency with the other three pricing files in the repository (generation-based-subscription, tiered-usage-gated-subscription, and usage-limit-subscription), which all continue to use theprices:array format.Before this change can be merged, verify whether:
- The schema should align with Flowglad's documented format (
prices:array per product)- All four pricing files need to be updated consistently
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pay-as-you-go/pricing.yaml
🔇 Additional comments (3)
pay-as-you-go/pricing.yaml (3)
19-30: LGTM! Free Plan pricing structure updated correctly.The conversion from
pricesarray topriceobject is clean. The single-payment free plan configuration withunitPrice: 0and appropriate null values for recurring fields is correct.
39-49: LGTM! Usage-based pricing structure updated correctly.The conversion maintains all fields properly. The usage-type price with
unitPrice: 0andusageMeterSlug: "message_credits"correctly references the usage meter defined later in the file.
58-69: LGTM! Message Topup pricing structure updated correctly.The single-payment topup product is properly configured with
unitPrice: 10000and correctly references the "100_messages" feature grant.
angihe93
left a comment
There was a problem hiding this comment.
nice, would be good to update the other yamls too
The previous
pricing.yamlwas not able to be imported into Flowglad as a pricing model. I re-exported it to update the pricing file.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.