dockerfile: Windows Containers image Fluent Bit NMake build#10180
Merged
edsiper merged 10 commits intofluent:masterfrom Apr 21, 2025
Merged
dockerfile: Windows Containers image Fluent Bit NMake build#10180edsiper merged 10 commits intofluent:masterfrom
edsiper merged 10 commits intofluent:masterfrom
Conversation
mabrarov
requested review from
celalettin1286,
niedbalski and
patrick-stephens
as code owners
This was referenced Apr 7, 2025
mabrarov
force-pushed
the
feature/windows_container_nmake
branch
from
372305f to
da875e4
Compare
mabrarov
changed the title
mabrarov
force-pushed
the
feature/windows_container_nmake
branch
from
da875e4 to
70467a4
Compare
mabrarov
force-pushed
the
feature/windows_container_nmake
branch
from
70467a4 to
22fa55e
Compare
…nners due to deprecation of Ubuntu 20.04 runners (actions/runner-images#11101). Signed-off-by: Marat Abrarov <abrarov@gmail.com>
…CMake projects not compatible with CMake 4.0 (actions/runner-images#11926). Signed-off-by: Marat Abrarov <abrarov@gmail.com>
…ne for unit tests on s390x and riscv64. Signed-off-by: Marat Abrarov <abrarov@gmail.com>
…to ensure no build issue due to incompatibility with new CMake versions. Signed-off-by: Marat Abrarov <abrarov@gmail.com>
…ported one for Linux containers. Signed-off-by: Marat Abrarov <abrarov@gmail.com>
Signed-off-by: Marat Abrarov <abrarov@gmail.com>
Signed-off-by: Marat Abrarov <abrarov@gmail.com>
…t Bit within building of image for Windows Containers. Signed-off-by: Marat Abrarov <abrarov@gmail.com>
Signed-off-by: Marat Abrarov <abrarov@gmail.com>
mabrarov
force-pushed
the
feature/windows_container_nmake
branch
from
c1a0b3d to
df6afec
Compare
Signed-off-by: Eduardo Silva Pereira <eduardo@calyptia.com>
Member
|
note: I found some conflicts, I tried to fix them manually ... |
Contributor
Author
mabrarov
commented
Jun 22, 2025
| SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] | ||
|
|
||
| # Install Visual Studio Build Tools 2019 | ||
| # Install Visual Studio Build Tools 2019 (MSVS_VERSION=16) / 2022 (MSVS_VERSION=17, requires WINDOWS_VERSION=ltsc2022) |
Contributor
Author
There was a problem hiding this comment.
MSVS_VERSION=17 (Visual Studio Build Tools 2022) can be used even with WINDOWS_VERSION=ltsc2019:
$ docker build -t fluent/fluent-bit --build-arg MSVS_VERSION=17 -f dockerfiles/Dockerfile.windows .
...
Downloading Visual Studio Build Tools...
https://aka.ms/vs/17/release/vs_buildtools.exe -> C:\Users\ContainerAdministrator\AppData\Local\Temp\vs_buildtools.exe
https://aka.ms/vs/17/release/channel -> C:\local\VisualStudio.chman
Installing Visual Studio Build Tools into C:\BuildTools...
...
Successfully tagged fluent/fluent-bit:latest
$ docker run --rm fluent/fluent-bit --version
Fluent Bit v4.0.4
...
$ docker run --rm --entrypoint cmd fluent/fluent-bit
Microsoft Windows [Version 10.0.17763.678]
(c) 2018 Microsoft Corporation. All rights reserved.
...Moreover, GitHub actions for this repository use windows-latest runner (including test execution for pull requests) which hosts Visual Studio 2022. It means that CI/CD builds Fluent Bit for Windows on Windows Server 2022 using Visual C++ 2022, except Docker image for Windows.
Visual Studio 2022 supports Windows Server 2019 - refer to https://learn.microsoft.com/en-us/visualstudio/releases/2022/system-requirements#supported-operating-systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on (includes) #10178 and provides workaround for #10158 by using NMake (instead of MSBuild) when building Fluent Bit as part of building image for Windows Containers.
Changes (excluding #10178):
Testing
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.