Skip to content

tests: runtime: out_es: remove op_type to fix failing test#4480

Closed
nokute78 wants to merge 1 commit into
fluent:masterfrom
nokute78:fix_es_index_tests
Closed

tests: runtime: out_es: remove op_type to fix failing test#4480
nokute78 wants to merge 1 commit into
fluent:masterfrom
nokute78:fix_es_index_tests

Conversation

@nokute78
Copy link
Copy Markdown
Contributor

#4361 (comment)

out_es test failed on flb_test_index_type and flb_test_logstash_format since they expect index op_type .
Currently we use create op_type and it causes test failing.
7f0db9e

I removed index op_type from expected output string.
We try to support other op_type on #4079.
I think we should not take care op_type on such test cases.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • [N/A] Documentation required for this feature

Debug output

$ bin/flb-rt-out_elasticsearch 
Test div0_error...                              [2021/12/18 10:42:16] [ info] [engine] started (pid=32252)
[2021/12/18 10:42:16] [ info] [storage] version=1.1.5, initializing...
[2021/12/18 10:42:16] [ info] [storage] in-memory
[2021/12/18 10:42:16] [ info] [storage] normal synchronization mode, checksum disabled, max_chunks_up=128
[2021/12/18 10:42:16] [ info] [cmetrics] version=0.2.2
[2021/12/18 10:42:16] [ info] [sp] stream processor started
[2021/12/18 10:42:16] [ info] [task] cleanup test task
[2021/12/18 10:42:18] [ warn] [engine] service will shutdown in max 1 seconds
[2021/12/18 10:42:18] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test index_type...                              [2021/12/18 10:42:18] [ info] [engine] started (pid=32255)
[2021/12/18 10:42:18] [ info] [storage] version=1.1.5, initializing...
[2021/12/18 10:42:18] [ info] [storage] in-memory
[2021/12/18 10:42:18] [ info] [storage] normal synchronization mode, checksum disabled, max_chunks_up=128
[2021/12/18 10:42:18] [ info] [cmetrics] version=0.2.2
[2021/12/18 10:42:18] [ info] [sp] stream processor started
[2021/12/18 10:42:19] [ info] [task] cleanup test task
[2021/12/18 10:42:20] [ warn] [engine] service will shutdown in max 1 seconds
[2021/12/18 10:42:21] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test logstash_format...                         [2021/12/18 10:42:21] [ info] [engine] started (pid=32258)
[2021/12/18 10:42:21] [ info] [storage] version=1.1.5, initializing...
[2021/12/18 10:42:21] [ info] [storage] in-memory
[2021/12/18 10:42:21] [ info] [storage] normal synchronization mode, checksum disabled, max_chunks_up=128
[2021/12/18 10:42:21] [ info] [cmetrics] version=0.2.2
[2021/12/18 10:42:21] [ info] [sp] stream processor started
[2021/12/18 10:42:22] [ info] [task] cleanup test task
[2021/12/18 10:42:23] [ warn] [engine] service will shutdown in max 1 seconds
[2021/12/18 10:42:24] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test logstash_format_nanos...                   [2021/12/18 10:42:24] [ info] [engine] started (pid=32261)
[2021/12/18 10:42:24] [ info] [storage] version=1.1.5, initializing...
[2021/12/18 10:42:24] [ info] [storage] in-memory
[2021/12/18 10:42:24] [ info] [storage] normal synchronization mode, checksum disabled, max_chunks_up=128
[2021/12/18 10:42:24] [ info] [cmetrics] version=0.2.2
[2021/12/18 10:42:24] [ info] [sp] stream processor started
[2021/12/18 10:42:25] [ info] [task] cleanup test task
[2021/12/18 10:42:26] [ warn] [engine] service will shutdown in max 1 seconds
[2021/12/18 10:42:27] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test tag_key...                                 [2021/12/18 10:42:27] [ info] [engine] started (pid=32264)
[2021/12/18 10:42:27] [ info] [storage] version=1.1.5, initializing...
[2021/12/18 10:42:27] [ info] [storage] in-memory
[2021/12/18 10:42:27] [ info] [storage] normal synchronization mode, checksum disabled, max_chunks_up=128
[2021/12/18 10:42:27] [ info] [cmetrics] version=0.2.2
[2021/12/18 10:42:27] [ info] [sp] stream processor started
[2021/12/18 10:42:28] [ info] [task] cleanup test task
[2021/12/18 10:42:29] [ warn] [engine] service will shutdown in max 1 seconds
[2021/12/18 10:42:30] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test replace_dots...                            [2021/12/18 10:42:30] [ info] [engine] started (pid=32267)
[2021/12/18 10:42:30] [ info] [storage] version=1.1.5, initializing...
[2021/12/18 10:42:30] [ info] [storage] in-memory
[2021/12/18 10:42:30] [ info] [storage] normal synchronization mode, checksum disabled, max_chunks_up=128
[2021/12/18 10:42:30] [ info] [cmetrics] version=0.2.2
[2021/12/18 10:42:30] [ info] [sp] stream processor started
[2021/12/18 10:42:31] [ info] [task] cleanup test task
[2021/12/18 10:42:32] [ warn] [engine] service will shutdown in max 1 seconds
[2021/12/18 10:42:33] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test id_key...                                  [2021/12/18 10:42:33] [ info] [engine] started (pid=32270)
[2021/12/18 10:42:33] [ info] [storage] version=1.1.5, initializing...
[2021/12/18 10:42:33] [ info] [storage] in-memory
[2021/12/18 10:42:33] [ info] [storage] normal synchronization mode, checksum disabled, max_chunks_up=128
[2021/12/18 10:42:33] [ info] [cmetrics] version=0.2.2
[2021/12/18 10:42:33] [ info] [sp] stream processor started
[2021/12/18 10:42:34] [ info] [task] cleanup test task
[2021/12/18 10:42:35] [ warn] [engine] service will shutdown in max 1 seconds
[2021/12/18 10:42:36] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
SUCCESS: All unit tests have passed.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
@nokute78
Copy link
Copy Markdown
Contributor Author

If #4361 is merged, the issue #4361 (comment) will be fixed without this PR.

@edsiper
Copy link
Copy Markdown
Member

edsiper commented Dec 18, 2021

@nokute78 #4361 was just merged, thanks

@nokute78 nokute78 marked this pull request as draft December 18, 2021 23:25
@nokute78
Copy link
Copy Markdown
Contributor Author

@edsiper Oops, I was wrong.

If #4361 is merged, the issue #4361 (comment) will be fixed without this PR.

It should be #4079.
I converted to draft PR to wait merging #4079.

@edsiper
Copy link
Copy Markdown
Member

edsiper commented Jan 7, 2022

@nokute78 #4079 has been merged.

@nokute78
Copy link
Copy Markdown
Contributor Author

nokute78 commented Jan 8, 2022

@edsiper Thank you for information.
I close this PR since the out_es test of master works correctly.

@nokute78 nokute78 closed this Jan 8, 2022
@nokute78 nokute78 deleted the fix_es_index_tests branch January 8, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants