out_prometheus_exporter: Return 204 on no metrics#9614
Open
jplitza wants to merge 1 commit intofluent:masterfrom
Open
out_prometheus_exporter: Return 204 on no metrics#9614jplitza wants to merge 1 commit intofluent:masterfrom
jplitza wants to merge 1 commit intofluent:masterfrom
Conversation
Especially when using log_to_metrics or directly after startup, it might well be that no metrics are available yet. This isn't an error condition, so don't return a 4xx code! Signed-off-by: Jan-Philipp Litza <jplitza@users.noreply.github.com>
jplitza
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
Author
|
@edsiper Thanks for triggering the Actions! The failing test about in_kubernetes on macos and the failing build on s390x don't seem to be related to my change. |
cosmo0920
approved these changes
Nov 29, 2024
Contributor
cosmo0920
left a comment
cosmo0920
left a comment
There was a problem hiding this comment.
This seems reasonable to me. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially when using log_to_metrics or directly after startup, it might well be that no metrics are available yet. This isn't an error condition, so don't return a 4xx code!
Fixes #9366
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.