deb rpm: fix local dependency gem#688
Merged
daipom merged 2 commits intoNov 1, 2024
Merged
Conversation
kenhys
force-pushed
the
fix-local-dependency-gem
branch
3 times, most recently
from
October 18, 2024 07:19
fda97f6 to
73a9d59
Compare
kenhys
marked this pull request as ready for review
October 18, 2024 07:19
kenhys
force-pushed
the
fix-local-dependency-gem
branch
10 times, most recently
from
October 21, 2024 05:46
e3d2b34 to
930444b
Compare
Contributor
Author
|
service restart may need some more tweaks in rpm CI, but it is out of this PR. |
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
October 21, 2024 06:42
930444b to
04d8157
Compare
Contributor
Author
|
TODO: add missing test case |
kenhys
force-pushed
the
fix-local-dependency-gem
branch
5 times, most recently
from
October 22, 2024 02:55
2e71072 to
18bafd1
Compare
daipom
reviewed
Oct 22, 2024
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
October 22, 2024 03:07
18bafd1 to
5dfe5c2
Compare
daipom
reviewed
Oct 22, 2024
kenhys
force-pushed
the
fix-local-dependency-gem
branch
2 times, most recently
from
October 22, 2024 05:29
54e397f to
f264999
Compare
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
October 30, 2024 07:48
0ea2ce3 to
7cd0738
Compare
Contributor
Author
|
Fixed typo in postinst |
kenhys
force-pushed
the
feature-nodowntime
branch
from
October 31, 2024 01:56
57df978 to
4199d11
Compare
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
October 31, 2024 02:04
7cd0738 to
b71b070
Compare
Contributor
Author
|
rebased with recent feature branch. |
daipom
reviewed
Oct 31, 2024
Contributor
|
Let's cache v6 dummy - name: cache deb
uses: actions/cache@v4
id: cache-deb
with:
path: |
fluent-package/apt/repositories
fluent-apt-source/apt/repositories
fluent-lts-apt-source/apt/repositories
+ v6-test/fluent-package/apt/repositories
key: ${{ runner.os }}-cache-${{ matrix.rake-job }}-${{ hashFiles('**/config.rb', '**/Rakefile', '**/Gemfile*', 'fluent-package/templates/**', 'fluent-package/debian/**', 'fluent-package/apt/**/Dockerfile') }}
- name: Build deb with Docker
if: ${{ ! steps.cache-deb.outputs.cache-hit }}
run: |
rake apt:build APT_TARGETS=${{ matrix.rake-job }}
- uses: actions/checkout@master
+ if: ${{ ! steps.cache-deb.outputs.cache-hit }}
with:
path: v6-test
- name: Build v6 deb with Docker
+ if: ${{ ! steps.cache-deb.outputs.cache-hit }}
run: |
cd v6-test
git config user.email "fluentd@googlegroups.com"
git config user.name "Fluentd developers"
git am fluent-package/bump-version-v6.patch
rake apt:build APT_TARGETS=${{ matrix.rake-job }} |
kenhys
force-pushed
the
fix-local-dependency-gem
branch
2 times, most recently
from
October 31, 2024 07:39
e05447b to
7fe1eed
Compare
Contributor
Author
|
Fixed not matched local_missing_plugins. |
daipom
reviewed
Oct 31, 2024
kenhys
force-pushed
the
fix-local-dependency-gem
branch
2 times, most recently
from
October 31, 2024 08:07
d59be52 to
a04c249
Compare
daipom
reviewed
Oct 31, 2024
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
October 31, 2024 08:14
2f243d3 to
ba84806
Compare
daipom
reviewed
Oct 31, 2024
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
October 31, 2024 09:04
ba84806 to
d94cdb3
Compare
Contributor
Author
|
resolved conflict. |
kenhys
force-pushed
the
fix-local-dependency-gem
branch
2 times, most recently
from
October 31, 2024 09:24
e6a4c01 to
4e11674
Compare
daipom
reviewed
Nov 1, 2024
Before: * missing fluent-plugin was installed After: * missing fluent-plugin was installed * missing dependency gem was also installed NOTE: * if missing gem requires development packages to build it, it will fail. * fluent-diagtool depends on highly systemd service, so it is simple just to use fluent-gem detecting missing gems. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
When major upgrade process was executed, manually installed plugin/gem should be installed in advance. This PR test whether that mechanism will be launched. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
fix-local-dependency-gem
branch
from
November 1, 2024 03:18
7bbf81d to
55dd93d
Compare
Contributor
Author
|
NOTE:
|
Contributor
|
(ボタン押し間違えました 🙇 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
NOTE:
fail.
just to use fluent-gem detecting missing gems.