Skip to content

auto plugin install: disable unless auto#756

Merged
daipom merged 1 commit into
fluent:feature-nodowntimefrom
daipom:disable-auto-plugin-install-unless-auto
Dec 9, 2024
Merged

auto plugin install: disable unless auto#756
daipom merged 1 commit into
fluent:feature-nodowntimefrom
daipom:disable-auto-plugin-install-unless-auto

Conversation

@daipom

@daipom daipom commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

This allows users to manually manage plugins by setting FLUENT_PACKAGE_SERVICE_RESTART to manual.

For example, there will be cases where a user wants to use a particular plugin version.

@daipom
daipom force-pushed the disable-auto-plugin-install-unless-auto branch from 964eb2a to 664ed6b Compare December 6, 2024 01:37
@daipom
daipom marked this pull request as ready for review December 6, 2024 05:03
@daipom
daipom requested review from Watson1978 and kenhys December 6, 2024 05:03
@daipom
daipom force-pushed the feature-nodowntime branch from 2ee719f to e5a6e5a Compare December 6, 2024 07:09
@daipom
daipom force-pushed the disable-auto-plugin-install-unless-auto branch from 664ed6b to 2605fce Compare December 6, 2024 07:09
This allows users to manually manage plugins by setting
FLUENT_PACKAGE_SERVICE_RESTART to manual.

For example, there will be cases where a user wants to use a
particular plugin version.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom
daipom force-pushed the disable-auto-plugin-install-unless-auto branch from 2605fce to bfcc5ee Compare December 9, 2024 01:53
@daipom

daipom commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

Rebased.

@Watson1978 Watson1978 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

if [ $1 -eq 2 ]; then
# collect installed gems during upgrading
/usr/sbin/fluent-gem list '^fluent-plugin-' --no-versions --no-verbose > %{local_base_plugins}
. %{_sysconfdir}/sysconfig/@SERVICE_NAME@

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can fail when updating from v4.
For some reason, the current test is successful.
I will check these concerns together last.

@kenhys kenhys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daipom
daipom merged commit e381cb5 into fluent:feature-nodowntime Dec 9, 2024
@daipom
daipom deleted the disable-auto-plugin-install-unless-auto branch December 9, 2024 08:46
daipom added a commit to daipom/fluent-package-builder that referenced this pull request Dec 10, 2024
This allows users to manually manage plugins by setting
FLUENT_PACKAGE_SERVICE_RESTART to manual.

For example, there will be cases where a user wants to use a particular
plugin version.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom added a commit to daipom/fluent-package-builder that referenced this pull request Dec 10, 2024
This allows users to manually manage plugins by setting
FLUENT_PACKAGE_SERVICE_RESTART to manual.

For example, there will be cases where a user wants to use a particular
plugin version.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
kenhys pushed a commit that referenced this pull request Dec 11, 2024
This allows users to manually manage plugins by setting
FLUENT_PACKAGE_SERVICE_RESTART to manual.

For example, there will be cases where a user wants to use a particular
plugin version.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@kenhys kenhys added this to the 5.2.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants