deb rpm: remove manual feature of zero-downtime-restart from uninstall phase - #758
Merged
daipom merged 1 commit intoDec 9, 2024
Conversation
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
changed the title
Contributor
|
Thanks! Looks good! |
Watson1978
marked this pull request as ready for review
December 9, 2024 04:44
daipom
approved these changes
Dec 9, 2024
Contributor
|
Thanks! |
daipom
pushed a commit
to daipom/fluent-package-builder
that referenced
this pull request
Dec 10, 2024
…l phase (fluent#758) We were going to support two methods of downgrading with zero downtime. 1. Running v6.x => Install v5.x package by overwriting 2. Running v6.x => Replace `FLUENT_PACKAGE_SERVICE_RESTART` value to `manual` => uninstall v6.x => Install v5.x The second method is to keep the Fluentd process running after uninstalling it. We decided to remove `2.` method because it may cause confusion for users. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
daipom
pushed a commit
to daipom/fluent-package-builder
that referenced
this pull request
Dec 10, 2024
…l phase (fluent#758) We were going to support two methods of downgrading with zero downtime. 1. Running v6.x => Install v5.x package by overwriting 2. Running v6.x => Replace `FLUENT_PACKAGE_SERVICE_RESTART` value to `manual` => uninstall v6.x => Install v5.x The second method is to keep the Fluentd process running after uninstalling it. We decided to remove `2.` method because it may cause confusion for users. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
kenhys
pushed a commit
that referenced
this pull request
Dec 11, 2024
…l phase (#758) We were going to support two methods of downgrading with zero downtime. 1. Running v6.x => Install v5.x package by overwriting 2. Running v6.x => Replace `FLUENT_PACKAGE_SERVICE_RESTART` value to `manual` => uninstall v6.x => Install v5.x The second method is to keep the Fluentd process running after uninstalling it. We decided to remove `2.` method because it may cause confusion for users. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were going to support two methods of downgrading with zero downtime.
FLUENT_PACKAGE_SERVICE_RESTARTvalue tomanual=> uninstall v6.x => Install v5.xThe second method is to keep the Fluentd process running after uninstalling it.
We decided to remove
2.method because it may cause confusion for users.