Skip to content

Restricts prometheus-client version - #120

Closed
ganmacs wants to merge 1 commit into
fluent:masterfrom
ganmacs:restrics-prometheus-client-version
Closed

Restricts prometheus-client version#120
ganmacs wants to merge 1 commit into
fluent:masterfrom
ganmacs:restrics-prometheus-client-version

Conversation

@ganmacs

@ganmacs ganmacs commented Oct 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

hotfix for #119

New version(0.10.0) has no compatibility with an older version.

This is a temporary solution. We need to catch up new version of prometeus-ruby.

@ganmacs
Restricts prometheus-client version
02b012f 
new version(0.10.0) has no compatibility with older version

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
@ganmacs
ganmacs force-pushed the restrics-prometheus-client-version branch from 6649e29 to 02b012f Compare October 8, 2019 02:48
repeatedly
repeatedly reviewed Oct 8, 2019
View reviewed changes
Comment thread fluent-plugin-prometheus.gemspec

spec.add_dependency "fluentd", ">= 0.14.20", "< 2"
spec.add_dependency "prometheus-client"
spec.add_dependency "prometheus-client", "~> 0.4.2"

@repeatedly repeatedly Oct 8, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 0.4.2, not 0.9.0?

@repeatedly repeatedly mentioned this pull request Oct 8, 2019
Merged
@kazegusuri

kazegusuri commented Oct 8, 2019

Copy link
Copy Markdown
Collaborator

I will check in this weekend.

@duxthefux

duxthefux commented Oct 8, 2019 •
edited
Loading

Copy link
Copy Markdown

@kazegusuri When can we expect the fixed version? This currently breaks our autoscaling in production.

Our temporary fix currently is td-agent-gem install fluent-plugin-prometheus && td-agent-gem install prometheus-client -v 0.9.0 && td-agent-gem uninstall prometheus-client -v 0.10.0

TBH: this is some serious issue which will affect many people using this plugin in production. Would really appreciate it if it could be merged and a new release created.

@repeatedly

repeatedly commented Oct 8, 2019

Copy link
Copy Markdown
Member

td-agent-gem install fluent-plugin-prometheus && td-agent-gem install prometheus-client -v 0.9.0 && td-agent-gem uninstall prometheus-client -v 0.10.0

Please install prometheus-client first. No need uninstall step.

@repeatedly

repeatedly commented Oct 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

I just released v1.6.1 because prometheus plugin is popular. cc: @kazegusuri

@repeatedly

repeatedly commented Oct 8, 2019

Copy link
Copy Markdown
Member

close via #121

@repeatedly repeatedly closed this Oct 8, 2019
@duxthefux

duxthefux commented Oct 8, 2019

Copy link
Copy Markdown

thanks a lot!!!!

@ganmacs
ganmacs deleted the restrics-prometheus-client-version branch October 9, 2019 01:51
@ganmacs

ganmacs commented Oct 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

There is no guarantee 0.9.0(this version has not been released and may not going to be released) has compatibility with 0.4.2 or older versions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@repeatedly repeatedly repeatedly left review comments
@kazegusuri kazegusuri Awaiting requested review from kazegusuri

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ganmacs @kazegusuri @duxthefux @repeatedly