Fix outdated regexp of apache2 parser#647
Merged
Merged
Conversation
The regexp shown in parser/apache2.md was the one used before v1.14.2.
Escape sequences were first allowed by df5ac352 "Allow escape sequences in
Apache access log" (v0.14.14), which used `(?:[^\"]|\\.)`, and that is the
form the document still shows. The source was later narrowed by db93f4b9
"parser_apache2: Fix too wide matching regexp" (v1.14.2):
- REGEXP = ... (?<path>(?:[^\"]|\\.)*?) ... (?<referer>(?:[^\"]|\\.)*) ... (?<agent>(?:[^\"]|\\.)*) ...
+ REGEXP = ... (?<path>(?:[^\"]|\\")*?) ... (?<referer>(?:[^\"]|\\")*) ... (?<agent>(?:[^\"]|\\")*) ...
The document was not updated at that time. So it still says that any
backslash-escaped character is accepted in path, referer and agent, while
the current implementation accepts only an escaped double quote.
The new text is copied from Apache2Parser::REGEXP.source of the v1.19
branch and was compared with the document line to confirm they are
identical.
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
kenhys
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regexp shown in parser/apache2.md was the one used before v1.14.2.
The expression was updated at fluent/fluentd@db93f4b