Skip to content

filter-record-transformer: remove old behaviours - #1311

Merged
repeatedly merged 3 commits into
masterfrom
record-transformer-remove-old-behaviours
Nov 15, 2016
Merged

filter-record-transformer: remove old behaviours#1311
repeatedly merged 3 commits into
masterfrom
record-transformer-remove-old-behaviours

Conversation

@repeatedly

Copy link
Copy Markdown
Member

We got many questions "Why transformed result is string?"
Time to change default behaviour before stable v0.14.

@sonots Could you check this patch?

@repeatedly repeatedly added enhancement Feature request or improve operations v0.14 labels Nov 14, 2016
@repeatedly repeatedly changed the title Record transformer remove old behaviours filter-record-transformer: remove old behaviours Nov 14, 2016
@sonots

sonots commented Nov 14, 2016

Copy link
Copy Markdown
Member

I want to drop

too.
Dropping this enforces users to specify record keys as "record[key]", it enables to remove method_missing and we can improve performance as record_modifier does.

@sonots

sonots commented Nov 15, 2016

Copy link
Copy Markdown
Member

Codes look good, okay to merge this individually.

@repeatedly
repeatedly merged commit d3ae96b into master Nov 15, 2016
@repeatedly
repeatedly deleted the record-transformer-remove-old-behaviours branch November 15, 2016 01:12
@repeatedly

repeatedly commented Nov 15, 2016

Copy link
Copy Markdown
Member Author

@sonots Thanks for the review.

Dropping this enforces users to specify record keys as "record[key]"

This is good idea. Could you write a patch?
You are the best person to handle it.

Watson1978 added a commit to Watson1978/fluentd-docs-gitbook that referenced this pull request Jul 24, 2026
The default value was changed at fluent/fluentd#1311

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
kenhys added a commit to fluent/fluentd-docs-gitbook that referenced this pull request Jul 24, 2026
* Fix auto_typecast default value

The default value was changed at fluent/fluentd#1311

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Fix rate_period default value

The rate_period was introduced at fluent/fluentd#3535.
The default value was 5 from the beginning.

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Fix backlog default value

The backlog parameter was introduced at fluent/fluentd@48b5173

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Fix proto default value

The proto parameter was introduced at fluent/fluentd@adb82fb

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Fix parameter type of keepalive_timeout

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Fix parameter type of emit_interval

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Fix parameter type of tls_cert_use_enterprise_store

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Update introduced version

Co-authored-by: Kentaro Hayashi <kenhys@gmail.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Update introduced version

Co-authored-by: Kentaro Hayashi <kenhys@gmail.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Update introduced version

Co-authored-by: Kentaro Hayashi <kenhys@gmail.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Update introduced version

Co-authored-by: Kentaro Hayashi <kenhys@gmail.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

* Update introduced version

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>

---------

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Co-authored-by: Kentaro Hayashi <kenhys@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature request or improve operations v0.14

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants