Skip to content

support config delimiter in syslog plugin - #2378

Merged
repeatedly merged 1 commit into
fluent:masterfrom
abenbachir:syslog-support-delimiter
Apr 11, 2019
Merged

support config delimiter in syslog plugin#2378
repeatedly merged 1 commit into
fluent:masterfrom
abenbachir:syslog-support-delimiter

Conversation

@abenbachir

@abenbachir abenbachir commented Apr 10, 2019

Copy link
Copy Markdown
Contributor

There are softwares out there that still use NUL-terminating characters when sending events through TCP. Firewalls for example are used a lots, and it's impossible to change their behavior because they are closed source. Most Firewall implement RFC3164 or CEF protocol, so using in_syslog plugin comes very usefull than in_tcp plugin.
I'm adding delimiter we can edit the default delimiter ("\n") from configuration, similar to in_tcp plugin.

I made the change in v0.12, I can do the same for v1.x If this change is good to merge.

Something important to know is that NUL(\0) or newline(\n) characters must be used with double-quote in configuration:

<source>
    type syslog
    protocol_type tcp
    delimiter "\0"
</source>

Docs Changes:
I will update documentation when this PR make it

@abenbachir
abenbachir force-pushed the syslog-support-delimiter branch from acabadd to 1d7009e Compare April 10, 2019 18:54
@repeatedly

Copy link
Copy Markdown
Member

v0.12 will merge only security fix so please send this patch to master.

@abenbachir

abenbachir commented Apr 10, 2019

Copy link
Copy Markdown
Contributor Author

So you mean, this change will only make it to v1.x ?

@repeatedly

Copy link
Copy Markdown
Member

Yes.

@abenbachir
abenbachir force-pushed the syslog-support-delimiter branch from 1d7009e to 31c8fcd Compare April 10, 2019 21:07
@abenbachir
abenbachir changed the base branch from v0.12 to master April 10, 2019 21:07
Signed-off-by: Abderrahmane Benbachir <abderb@microsoft.com>
@abenbachir
abenbachir force-pushed the syslog-support-delimiter branch from 31c8fcd to 3e4327a Compare April 10, 2019 21:09
@abenbachir

Copy link
Copy Markdown
Contributor Author

Done

@repeatedly
repeatedly merged commit 607c43c into fluent:master Apr 11, 2019
@repeatedly

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants