Skip to content

in_tail: Add switch_io_after_read parameter. fix #2478 - #2525

Closed
repeatedly wants to merge 1 commit into
masterfrom
in_tail-add-parameter-for-io-switch
Closed

in_tail: Add switch_io_after_read parameter. fix #2478#2525
repeatedly wants to merge 1 commit into
masterfrom
in_tail-add-parameter-for-io-switch

Conversation

@repeatedly

Copy link
Copy Markdown
Member

Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com

Which issue(s) this PR fixes:
Fixes #2478

What this PR does / why we need it:
Add switch_io_after_read parameter to control IO read operation.
I tested several cases and no problem. But I can't say all environment have no problem with this change so I add parameter for smooth migration.

Docs Changes:
Will submit a PR to add parameter for v1.6.3.

Release Note:
Same as title.

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly repeatedly added the enhancement Feature request or improve operations label Jul 26, 2019
@repeatedly
repeatedly requested a review from ganmacs July 26, 2019 05:11
@repeatedly repeatedly self-assigned this Jul 26, 2019
@ganmacs

ganmacs commented Jul 26, 2019

Copy link
Copy Markdown
Member

According to this comment #2478 (comment), I think @fifo and the contents of a file should be flushed not to lost the data when detaching.

resolve this by setting rotate_wait to a bigger value

I think this is good for a workaround. but not for the final solution.

@ashie

ashie commented May 11, 2021

Copy link
Copy Markdown
Member

It seems that #3185 is now going to include this fix.
I'll close this if #3185 is landed with similar implementation with this.
On the other hand, it doesn't yet resolve problems mentioned in #2478 (comment), so further work is needed.

@ashie

ashie commented May 11, 2021

Copy link
Copy Markdown
Member

#3185 has been merged.
Setting read_bytes_limit_per_second to 8192 (or less than it) will take same effect with this.

@ashie ashie closed this May 11, 2021
@kenhys
kenhys deleted the in_tail-add-parameter-for-io-switch branch December 26, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature request or improve operations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in_tail take long time to found rotated files

3 participants